Cherry pick about 13 PRs into release-1.19 #6405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add metadata tags for documentation * Add classification for about 2/3rds of docs (func + eventing) * Add classification for remainder of docs (serving+install)
* Publish threat model in documentation * Separate security contents a bit more, update link to threat model, update nav * Add a section on supply chain and SBOM/SLSA mitigation * Update threat model with feedback from David Hadas * Update introduction with content from davidhadas, add sections on controller and webhook functionality and update targets of threats
…#6366) * add dry run section * drop mention of old feature flag * fix casing on nav * update docs to be more clear and include inline example --------- Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
…ive#6371) * Attempt to rebuild docs build process * Use a more modern python version * Fix strict verify, hide versions on unversioned pages
Hopefully, this can be fixed upstream via PR shortly.
* Installation Doc Updates Improve installation guidance * Formatting fix * Update docs/install/README.md link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update docs/install/README.md link fix Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * link fix and table update More writing * Update README.md Misc edits * Update README.md Minor edits * Adding install-kn to PR Consolidating CLI installations into this this topic. * Update install-kn.md Changing red bug alert to important The old syntax was: ??? bug "Having issues upgrading `kn` to Homebrew?" * Update install-kn (snippet) Removed alert formatting * Added quickstart-install.md Various edits * Fixes and reviewed edits Made Evan suggestions, table column test, spelling fixes * Update quickstart-install.md link fix * Update README.md Replaced the table with a bulleted list approach. * Update README.md Put back the table * Added serving and eventing install topics Updated topics per effort - consolidating guidance * Link fixes * Made Evan's edits * Various updates All files added for this PR. * Link fix * Formatting fixes * Formatting and consistency fix * Update docs/install/operator/knative-with-operator-cli.md Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update docs/client/install-kn.md Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> --------- Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
I have copy-pasted from the Knative Serving documentation page the block as I found it missing when configuring it.
Undo separeate kn func output for invoke
knative-prow
bot
added
approved
|
I'm going to do a PR to main to fix the style linting issues that somehow didn't show up earlier. |
|
There are 3 typos, and 1 false-positive typo, but I don't think they need to block this cherrypick. |
|
/assign @dprotaso |
|
/hold It looks like there might be a few redirects to fix. |
knative-prow
bot
added
the
do-not-merge/hold
|
I fixed the redirects in the cherry-pick. I'll get another PR started for the style warnings. I think I also figured out how to speed up the clones by a non-trivial amount using |
Merged
|
Unsure if this existed before on this branch but running ERROR - Error building page 'index.md': 'NoneType' object is not iterable
Traceback (most recent call last):
File "/usr/local/bin/mkdocs", line 7, in <module>
sys.exit(cli())
^^^^^
File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1442, in __call__
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1363, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1830, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1226, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/click/core.py", line 794, in invoke
return callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/mkdocs/__main__.py", line 272, in serve_command
serve.serve(**kwargs)
File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 85, in serve
builder(config)
File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 67, in builder
build(config, serve_url=None if is_clean else serve_url, dirty=is_dirty)
File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/build.py", line 337, in build
_build_page(
File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/build.py", line 223, in _build_page
output = template.render(context)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/jinja2/environment.py", line 1295, in render
self.environment.handle_exception()
File "/usr/local/lib/python3.11/site-packages/jinja2/environment.py", line 942, in handle_exception
raise rewrite_traceback_stack(source=source)
File "/site/overrides/home.html", line 1, in top-level template code
{% extends "main.html" %} {% block content %}
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/site/overrides/main.html", line 1, in top-level template code
{% extends "base.html" %}
File "/usr/local/lib/python3.11/site-packages/material/templates/base.html", line 154, in top-level template code
{% block site_nav %}
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/material/templates/base.html", line 162, in block 'site_nav'
{% include "partials/nav.html" %}
^^^^^^^^^
File "/site/overrides/partials/nav.html", line 72, in top-level template code
{% for nav_item in nav.children %}
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/jinja2/runtime.py", line 424, in __init__
self._iterator = self._to_iterator(iterable)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/jinja2/runtime.py", line 432, in _to_iterator
return iter(iterable)
^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not iterable |
|
Prior it had I guess technically we're using the build script on |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
knative-prow
bot
merged commit a3276b6
into
knative:release-1.19
18 of 19 checks passed
dprotaso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks the following PRs:
Only a few had painful merges: #6274 and #6371 in particular, because we'd partially pulled in subsequent PRs. Note that changes which fix the homepage and/or templates aren't technically needed here, but I cherry-picked them so that #6398 (with all the moves) would apply cleanly -- and it did.