Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

[KafkaChannel] Use fanout config from Eventing #1413

Closed
pierDipi opened this issue Jul 28, 2020 · 4 comments
Closed

[KafkaChannel] Use fanout config from Eventing #1413

pierDipi opened this issue Jul 28, 2020 · 4 comments

Comments

@pierDipi
Copy link
Member

Use this fanout config https://github.com/knative/eventing/blob/master/pkg/channel/fanout/fanout_message_handler.go#L45 and then this function https://github.com/knative/eventing/blob/master/pkg/channel/fanout/fanout_message_handler.go#L93 does the job for you (so you can remove all the hacky code above for conversions)

Originally posted by @slinkydeveloper in #1408 (comment)

@slinkydeveloper
Copy link
Contributor

This might be connected to the work @aliok is already doing in #1407

@pierDipi
Copy link
Member Author

/area kafka

@pierDipi
Copy link
Member Author

This is fixed.

/close

@knative-prow-robot
Copy link
Contributor

@pierDipi: Closing this issue.

In response to this:

This is fixed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants