Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Update deps to master #1408

Merged
merged 10 commits into from
Jul 28, 2020
Merged

Update deps to master #1408

merged 10 commits into from
Jul 28, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jul 27, 2020 •
edited
Loading

Proposed Changes

  • Change deps version from .16 to master
  • hack/update-deps --upgrade
  • hack/update-codegen.sh
  • Fix compilation errors

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 27, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release labels Jul 27, 2020
@pierDipi
Copy link
Member Author

/cc @tzununbekov

@pierDipi pierDipi force-pushed the point-to-master-2 branch from d65391d to a766de5 Compare July 27, 2020 10:50
@aliok
Copy link
Member

aliok commented Jul 27, 2020

Thanks for doing this @pierDipi

@pierDipi
Copy link
Member Author

@aliok Happy to help!

@pierDipi pierDipi mentioned this pull request Jul 27, 2020
Merged
aliok
aliok approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for doing the changes in separate commits for easy review.
Let's get this merged once the build is green.

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 27, 2020
@aliok aliok mentioned this pull request Jul 28, 2020
Merged
@aliok
Copy link
Member

aliok commented Jul 28, 2020

/retest

@slinkydeveloper
Copy link
Contributor

/assign

@slinkydeveloper
Copy link
Contributor

@pierDipi can you rebase?

pierDipi added 6 commits July 28, 2020 13:23
@pierDipi
Update deps to master
52bfd74 
- Change deps version from `.16` to `master`
- `hack/update-deps --upgrade`
- `hack/update-codegen.sh`
- Fix compilation errors

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Inject *rest.Config
3b40733 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Set Broker class to MTChannelBasedBroker
e9e3c6d 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Fix TLS handshake error from 10.244.0.1:37938: server key missing
f5e14b3 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Fix Natss dispatcher reconciler isn't leader aware
ee40af2 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
WIP
565e8c9 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the point-to-master-2 branch from 4fa9f36 to 565e8c9 Compare July 28, 2020 11:23
@pierDipi
Copy link
Member Author

Rebased

pierDipi added 2 commits July 28, 2020 15:45
@pierDipi
Change import helpers -> helpers/source
9250e92 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Create a custom Config for multichannel fanout
4edc804 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Copy link
Member Author

Almost done, only TestCamelSource fails now!

@pierDipi
Run hack/update-codegen.sh
29883b1 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Copy link
Member Author 

Failed to get all test resources ready: failed waiting for {TypeMeta:{Kind:CamelSource APIVersion:sources.knative.dev/v1alpha1} ObjectMeta:{Name:e2e-camelsource GenerateName: Namespace:test-camel-source-26tf8 SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
        knative.dev/eventing/test/lib.(*Client).WaitForAllTestResourcesReadyOrFail

I'm not sure what happened to CamelSource

@pierDipi pierDipi mentioned this pull request Jul 28, 2020
Closed
@slinkydeveloper
Copy link
Contributor

@pierDipi because this pr is blocking the work in this repo, i think you can skip the test now and we open an issue to re-enable it

@pierDipi pierDipi mentioned this pull request Jul 28, 2020
Closed
@pierDipi
Skip TestCamelSource
cd3e04a 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/channel/pkg/dispatcher/dispatcher.go 59.0% 61.7% 2.7
natss/pkg/reconciler/dispatcher/natsschannel.go 84.1% 80.3% -3.8

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@knative-prow-robot knative-prow-robot merged commit e53faf9 into knative:master Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper left review comments

@aliok aliok aliok approved these changes

@matzew matzew Awaiting requested review from matzew

@sebgoa sebgoa Awaiting requested review from sebgoa

@steuhs steuhs Awaiting requested review from steuhs

@tzununbekov tzununbekov Awaiting requested review from tzununbekov

Assignees

@aliok aliok

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierDipi @aliok @slinkydeveloper @knative-metrics-robot @knative-prow-robot @googlebot