Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SinkBinding to v1beta1 #3544

Closed
6 of 8 tasks
nachocano opened this issue Jul 8, 2020 · 3 comments
Closed
6 of 8 tasks

Move SinkBinding to v1beta1 #3544

nachocano opened this issue Jul 8, 2020 · 3 comments
Assignees
Labels
area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@nachocano
Copy link
Contributor

nachocano commented Jul 8, 2020

Problem
We need to promote SinkBinding to v1beta1.
Some tasks this will entail, and can probably be done in different PRs.

  • v1beta1 types with UTs
  • add new version to CRD
  • defaulting and conversion webhook
  • Update docs and examples (most in knative/docs)
  • Migrate reconciler to v1beta1 with UTs
  • Update e2e tests to use v1beta1
  • Make v1beta the storage version. --> Decided to wait one release in order to do this
  • Storage migration task. --> If we don't change the storage version, then this is not needed then for now

Persona:
Developer

Exit Criteria
SinkBinding in v1beta1

Additional context (optional)
Some example PRs
types: #2407
defaulting: #2645
conversion: #2611, #2632
reconciler: #3075

@vaikas
Copy link
Contributor

vaikas commented Jul 16, 2020

Also need to run a storage version migration job after the storage has been flipped. Something like this:
https://github.com/knative/eventing/blob/master/config/pre-install/v0.16.0/storage-version-migration.yaml

@nachocano
Copy link
Contributor Author

Also need to run a storage version migration job after the storage has been flipped. Something like this:
https://github.com/knative/eventing/blob/master/config/pre-install/v0.16.0/storage-version-migration.yaml

Thanks I wasn't aware of this, as is my first conversion/migration issue.
Will add that now.

@nachocano
Copy link
Contributor Author

Added a separate issue for migration and flipping the storage bit, as it has to be done after 0.17 cuts.
#3615

Closing this issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants