Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SinkBinding v1beta1 the stored version and add a migration tool #3615

Closed
nachocano opened this issue Jul 16, 2020 · 7 comments
Closed
Assignees
Labels
area/api area/sources area/test-and-release Test infrastructure, tests or release kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@nachocano
Copy link
Contributor

Problem
In 0.17, we promoted SinkBinding to v1beta1.
This is to track that we should make v1beta1 the storage version for 0.18, and we should add a migration tool for it.
Similar to: https://github.com/knative/eventing/blob/master/config/pre-install/v0.16.0/storage-version-migration.yaml

Persona:
Which persona is this feature for?
Developer

Exit Criteria
SinkBinding in v1beta1 and able to migrate

Additional context (optional)
#3613

@lberk lberk added area/api area/sources area/test-and-release Test infrastructure, tests or release priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 27, 2020
@nachocano
Copy link
Contributor Author

/assign @nlopezgi

@nlopezgi
Copy link
Contributor

i think this can be closed now that #3895 is in

@nlopezgi
Copy link
Contributor

/close

@knative-prow-robot
Copy link
Contributor

@nlopezgi: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nlopezgi
Copy link
Contributor

/reopen
per #3895 (comment): we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

@knative-prow-robot
Copy link
Contributor

@nlopezgi: Reopened this issue.

In response to this:

/reopen
per #3895 (comment): we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nachocano
Copy link
Contributor Author

/close
Fixed by #3942
I think it didn't automatically close because the Fixes # needs to be in different lines...
Thanks @nlopezgi !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/sources area/test-and-release Test infrastructure, tests or release kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants