Add a job for migrating sinkbindings and containersource storage versions to v1beta1

[nlopezgi]

Fixes #3674, #3615

Proposed Changes

• Add a Preinstall job that migrates sinkbindings from v1alpha1 to v1beta1.
• Add a Preinstall job that migrates containersource from v1alpha1 to v1beta1.
• Similar to add a job for migrating broker storage versions to v1beta1 #3262

Release Note

• 🗑️ Remove feature or internal logic
  Eventing v1alpha1 API is removed.
  action required: You must run pre-install job prior to upgrading to get sinkbindings and containersource to v1beta1 API.

[matzew]

/assign @devguyio

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-conformance-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestChannelStatusSubscriber/Channel_has_required_status_subscriber_fields
test/conformance.TestChannelStatusSubscriber/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelStatusSubscriber

[nlopezgi]

/test pull-knative-eventing-conformance-tests

[nlopezgi]

/test pull-knative-eventing-unit-tests

[nlopezgi]

fyi @nachocano

[nachocano]

do we need eventing.knative.dev?

[nlopezgi]

removed, thanks for catching, I had just copy-pasted some of these bits from the 0.16.0 version

[nachocano]

Thanks @nlopezgi !!!
Quick question, should we also change their CRDs inside config/ so that they have the v1beta1 storage set to true?

@lionelvillard would you mind taking a quick look as I don't have much experience with migration. Looks good to me but just in case we are missing something...

/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nlopezgi]

Thanks @nlopezgi !!!
Quick question, should we also change their CRDs inside config/ so that they have the v1beta1 storage set to true?

@lionelvillard would you mind taking a quick look as I don't have much experience with migration. Looks good to me but just in case we are missing something...

/approve

If these need to be changed I can also modify them. Most of the changes here were just copying what I see in #3262. Any advice as to what else is needed here is appreciated.

[lionelvillard]

/hold

We had conversations about not putting the pre and post jobs in subdirectories with the version (in this case v0.18). Instead we should follow what serving is doing.

@vaikas @adamharwayne Do you agree?

[lionelvillard]

Besides my comment above:
/lgtm

[lionelvillard]

@Harwayne

[lionelvillard]

Talked to Ali. Unholding this PR as we can always move this to a different directory in a different PR.

/unhold

[nachocano]

@nlopezgi I think we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

[nlopezgi]

@nlopezgi I think we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

Is that similar to #3925? If so I'll get started on that

[nachocano]

@nlopezgi I think we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

Is that similar to #3925? If so I'll get started on that

yes!