Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging storage v1 #3925

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Messaging storage v1 #3925

merged 2 commits into from
Aug 26, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 25, 2020 •
edited
Loading

Fixes #3583

Proposed Changes

  • Make messaging.* v1 resources the stored version
  • Add those resources to migration job

Release Note


- 🧽 Update or clean up current behavior
Change storage versions of flows.* resources from v1beta1 to v1:
          - "channels.messaging.knative.dev"
          - "inmemorychannels.messaging.knative.dev"

action required: You must run pre-install job prior to upgrading to get messaging.* resources to v1 API.

Docs

No docs change necessary. The content at https://knative.dev/docs/install/upgrade-installation/#run-pre-install-tools-before-upgrade is good enough

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 25, 2020
@aliok aliok mentioned this pull request Aug 25, 2020
Merged
@aliok aliok force-pushed the messaging-storage-v1 branch from 6988412 to 2e773f5 Compare August 25, 2020 15:02
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 25, 2020
@aliok aliok changed the title [WIP] Messaging storage v1 Messaging storage v1 Aug 25, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2020
@aliok
Copy link
Member Author

aliok commented Aug 25, 2020

/hold

I thought all resources' reconcilers are updated to use v1 shape, but subscription reconciler isn't.

Let me exclude subscriptions in this PR

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 25, 2020
@aliok aliok mentioned this pull request Aug 25, 2020
Closed
@aliok
Copy link
Member Author

aliok commented Aug 25, 2020

/unhold

Excluded subscriptions.

Created this ticket to track things: #3929

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
nlopezgi
nlopezgi reviewed Aug 25, 2020
View reviewed changes
config/pre-install/v0.18.0/clusterrole.yaml
@@ -58,3 +58,16 @@ rules:
- "delete"
- "patch"
- "watch"
- apiGroups:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just add the groups and resources here to LOC 48 and 50?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlopezgi you mean messaging api group should come before eventing api group? or something else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to have a single apiGroups statement that includes the following resources:

      - "containersources"
      - "sinkbindings"	      
      - "channels"
      - "inmemorychannels"
      - "brokers"
      - "triggers"

given that for all resources the same verbs are listed?
Just to reduce a bit of verbosity, but in all senses a nit, so totally your choice to leave as is or collapse.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlopezgi not sure if that would work. These resources are from different apiGroups (eventing, messaging, etc.).
Let's leave as is and we can have a look later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! yeah, you are probably right. I think with #3943 my concern is addressed

@nlopezgi
Copy link
Contributor

small nit, feel free to resolve or leave as is if you think its cleaner. Otherwise
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@nlopezgi nlopezgi mentioned this pull request Aug 25, 2020
Merged
matzew
matzew approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@nlopezgi
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot merged commit f7f934c into knative:master Aug 26, 2020
@aliok aliok deleted the messaging-storage-v1 branch August 27, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlopezgi nlopezgi nlopezgi left review comments

@mattmoor mattmoor mattmoor left review comments

@matzew matzew matzew approved these changes

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@matzew matzew

@nlopezgi nlopezgi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make messaging.* v1 resources the stored version
6 participants
@aliok @nlopezgi @knative-prow-robot @matzew @mattmoor @googlebot