Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ContainerSource v1beta1 the stored version and add a migration tool #3674

Closed
bharattkukreja opened this issue Jul 21, 2020 · 4 comments · Fixed by #3895 or #3942
Closed

Make ContainerSource v1beta1 the stored version and add a migration tool #3674

bharattkukreja opened this issue Jul 21, 2020 · 4 comments · Fixed by #3895 or #3942
Assignees
Labels
area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@bharattkukreja
Copy link
Contributor

Problem
In 0.17, we promoted ContainerSource to v1beta1.
This is to track that we should make v1beta1 the storage version for 0.18, and we should add a migration tool for it.
Similar to: https://github.com/knative/eventing/blob/master/config/pre-install/v0.16.0/storage-version-migration.yaml

Persona:
Which persona is this feature for?
Developer

Exit Criteria
ContainerSource in v1beta1 and able to migrate

Additional context (optional)
#3426

@grantr grantr added this to the v0.18.0 milestone Aug 17, 2020
@grantr grantr added area/sources priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 17, 2020
@grantr
Copy link
Contributor

grantr commented Aug 17, 2020

Blocked until 0.17 release.

@grantr grantr modified the milestones: v0.18.0, Backlog Aug 17, 2020
@nachocano
Copy link
Contributor

/assign @nlopezgi

@nlopezgi
Copy link
Contributor

/reopen
per #3895 (comment): we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

@knative-prow-robot
Copy link
Contributor

@nlopezgi: Reopened this issue.

In response to this:

/reopen
per #3895 (comment): we also need to update the CRDs to mark that we are storing v1beta1 now, so that a fresh install has that, not just the updated clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
5 participants