Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ContainerSource to v1beta1 #3426

Closed
nachocano opened this issue Jun 26, 2020 · 7 comments
Closed

Move ContainerSource to v1beta1 #3426

nachocano opened this issue Jun 26, 2020 · 7 comments
Assignees
Labels
area/api kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@nachocano
Copy link
Contributor

nachocano commented Jun 26, 2020

Problem
We need to promote ContainerSource to v1beta1.
Some tasks this will entail, and can probably be done in different PRs.

  • v1beta1 types with UTs
  • add new version to CRD
  • defaulting and conversion webhook
  • Update docs and examples (most in knative/docs)
  • Migrate reconciler to v1beta1 with UTs
  • Update e2e tests to use v1beta1

Persona:
Developer

Exit Criteria
ContainerSource in v1beta1

Additional context (optional)
Some example PRs
types: #2407
defaulting: #2645
conversion: #2611, #2632
reconciler: #3075

@nachocano
Copy link
Contributor Author

fyi @bryeung

@nachocano
Copy link
Contributor Author

Synced offline with @bharattkukreja.
Decided to have e2e tests for v1alpha2 and v1beta1. So we should follow what SinkBinding is doing in their tests.
This should be done in multiple PRs as mentioned in the description

@grantr grantr added area/api priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 29, 2020
@matzew
Copy link
Member

matzew commented Jun 30, 2020

@n3wscott do we have similar issues for PingSource and SinkBi ding?

@nachocano
Copy link
Contributor Author

We should move flip the storage bit in 0.17. We should do so for 0.18.
And we should add a migration tool.
@bharattkukreja can you create an issue similar to #3615 to track that once this one is done?

@nachocano
Copy link
Contributor Author

nachocano commented Jul 21, 2020

We should move flip the storage bit in 0.17. We should do so for 0.18.
And we should add a migration tool.
@bharattkukreja can you create an issue similar to #3615 to track that once this one is done?

@bharattkukreja can we close this issue? I saw that the reconciler changes were merged, same with docs.
Were you able to create an issue to track the storage bit flip for 0.18?

@bharattkukreja
Copy link
Contributor

Yep, this issue can be closed. Issue to track the storage bit flip for 0.18: #3674

@nachocano
Copy link
Contributor Author

Fixed by PRs linked to the issue.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants