Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1beta1 ContainerSources types #3589

Merged
merged 3 commits into from
Jul 15, 2020
Merged

v1beta1 ContainerSources types #3589

merged 3 commits into from
Jul 15, 2020

Conversation

bharattkukreja
Copy link
Contributor

Part of #3426

Proposed Changes

  • Add ContainerSources v1beta1 types
  • Update deps

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 14, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 14, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1beta1/container_defaults.go Do not exist 100.0%
pkg/apis/sources/v1beta1/container_lifecycle.go Do not exist 89.7%
pkg/apis/sources/v1beta1/container_types.go Do not exist 66.7%
pkg/apis/sources/v1beta1/container_validation.go Do not exist 88.2%
pkg/apis/sources/v1beta1/test_helper.go Do not exist 100.0%

@nachocano
Copy link
Contributor

/lgtm
/approve

Thanks for doing this @bharattkukreja !!!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharattkukreja, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@knative-prow-robot knative-prow-robot merged commit 28f9f61 into knative:master Jul 15, 2020
@bharattkukreja bharattkukreja deleted the container-source-v1beta1 branch July 15, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@nachocano nachocano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bharattkukreja @knative-metrics-robot @nachocano @knative-prow-robot @googlebot