Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciler and e2e tests for ContainerSource V1Beta1 #3661

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Reconciler and e2e tests for ContainerSource V1Beta1 #3661

merged 2 commits into from
Jul 20, 2020

Conversation

bharattkukreja
Copy link
Contributor

Part of #3426

Proposed Changes

  • ContainerSource reconciler and e2e tests for v1beta1

Release Note

ContainerSource is now in v1beta1

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 20, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jul 20, 2020
@bharattkukreja bharattkukreja mentioned this pull request Jul 20, 2020
Merged
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@n3wscott
Copy link
Contributor

How did this get an LGTM? that is very strange. (not saying anything about the code, it seems prow LGTM'ed the wrong PR, I see no trail or review or comments.)

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharattkukreja, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bharattkukreja
Copy link
Contributor Author

How did this get an LGTM? that is very strange. (not saying anything about the code, it seems prow LGTM'ed the wrong PR, I see no trail or review or comments.)

@n3wscott I think that might be because @capri-xiyue gave an lgtm. (Not sure why it is not showing in the conversation. Could be because she is not listed as an approver).

@bharattkukreja
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 73475f0 into knative:master Jul 20, 2020
@bharattkukreja bharattkukreja deleted the container_sources_reconciler branch July 20, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@chizhg chizhg Awaiting requested review from chizhg

@lberk lberk Awaiting requested review from lberk

Assignees

@n3wscott n3wscott

@capri-xiyue capri-xiyue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bharattkukreja @n3wscott @knative-prow-robot @googlebot @capri-xiyue