Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SinkBinding v1beta1 defaults & conversion #3575

Merged
merged 16 commits into from
Jul 15, 2020
Merged

SinkBinding v1beta1 defaults & conversion #3575

merged 16 commits into from
Jul 15, 2020

Conversation

nachocano
Copy link
Contributor

@nachocano nachocano commented Jul 14, 2020 •
edited
Loading

Helps with #3544

Proposed Changes

  • 🎁 Adding SinkBinding v1beta1 defaults and conversion.
  • Update deps

Release Note

NONE

Docs

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 14, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 14, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jul 14, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2020
@nachocano nachocano mentioned this pull request Jul 14, 2020
Merged
@aliok
Copy link
Member

aliok commented Jul 14, 2020

/assign

nachocano added 4 commits July 14, 2020 09:04
@nachocano
Updating deps, moving to duckv1beta1
e046650
@nachocano
Merge remote-tracking branch 'upstream/master' into sinkbinding_v1beta1
447901a 
# Conflicts:
#	go.mod
#	go.sum
#	vendor/knative.dev/pkg/apis/duck/v1/addressable_types.go
#	vendor/knative.dev/pkg/apis/duck/v1/podspec_types.go
#	vendor/knative.dev/pkg/apis/duck/v1/source_types.go
#	vendor/knative.dev/pkg/apis/duck/v1/status_types.go
#	vendor/knative.dev/pkg/apis/duck/v1beta1/addressable_types.go
#	vendor/knative.dev/pkg/apis/duck/v1beta1/source_types.go
#	vendor/knative.dev/pkg/apis/duck/v1beta1/status_types.go
#	vendor/modules.txt
@nachocano
update deps again
47e5f53
@nachocano
Merge branch 'sinkbinding_v1beta1' into sb_defaults_conversion
7def87a
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 14, 2020
@nachocano nachocano changed the title [WIP] SinkBinding v1beta1 defaults & conversion SinkBinding v1beta1 defaults & conversion Jul 14, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2020
nachocano
nachocano commented Jul 14, 2020
View reviewed changes
@nachocano
Copy link
Contributor Author

/assign @vaikas
not entirely sure if I'm doing the right thing in the conversion... added a question there

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestContainerSource
test/e2e.TestSinkBindingV1Alpha2Deployment
test/e2e.TestSinkBindingV1Alpha2CronJob

@nachocano
Copy link
Contributor Author

/hold missing conversions to v1alpha1

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@nachocano
Copy link
Contributor Author

/hold cancel
Tests passing and conversion stuff fixed
@vaikas this should be ready for another look

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@nachocano
Copy link
Contributor Author

@capri-xiyue actually I changed the comments, but not entirely to what you suggested.
Take a look, other places are doing similar stuff

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1alpha2/sinkbinding_conversion.go 100.0% 64.3% -35.7

@capri-xiyue
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@knative-prow-robot knative-prow-robot merged commit 8adaecc into knative:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

@bharattkukreja bharattkukreja bharattkukreja left review comments

@capri-xiyue capri-xiyue capri-xiyue left review comments

@aliok aliok Awaiting requested review from aliok

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@aliok aliok

@vaikas vaikas

@capri-xiyue capri-xiyue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nachocano @knative-prow-robot @aliok @knative-test-reporter-robot @knative-metrics-robot @capri-xiyue @vaikas @bharattkukreja @googlebot