Make reconcilers use messaging.* v1 resources

[aliok]

Part of #3446

Make reconcilers use messaging.* v1 resources

[aliok]

/assign

[aliok]

/unassign

This is a big task and I will be on PTO for a week. Unassigning from myself in case somebody wants to pick it up.

[nlopezgi]

/assign

[nlopezgi]

The migration for channel and subscription might be blocked on a possible issue I have identified in #3789. Copying (with modifications) the comment I have there and bringing it here for better visibility:

I think there is some missing bits in the type migration from v1beta1 -> v1. Need confirmation from someone with more experience before I can proceed to make changes to the types.

Currently, the ChannelableCombined is a type that represents a skeleton type wrapping Subscribable and Addressable of both v1alpha1 and v1beta1 duck types.

I think that as part of the types migration we need to add something else there for the Subscribable and Addressable for v1, otherwise I'm not quite sure how to make a reconciler that can work with the ChannelableCombined properly.

Advice thoughts are much appreciated!

[n3wscott]

I think you will want to add the v1 shape to ChannelableCombined to make progress.

If there are missing fields we need to know asap, it will cause a huge storage headache for us in the next release with v1 going out. There should be round trip tests to catch this. v1 -> v1beta1 -> v1 should be lossless.

[nlopezgi]

I think you will want to add the v1 shape to ChannelableCombined to make progress.

If there are missing fields we need to know asap, it will cause a huge storage headache for us in the next release with v1 going out. There should be round trip tests to catch this. v1 -> v1beta1 -> v1 should be lossless.

Thanks for confirming. I'll prepare a PR to add the v1 shape to ChannelableCombined

[nlopezgi]

I think you will want to add the v1 shape to ChannelableCombined to make progress.

If there are missing fields we need to know asap, it will cause a huge storage headache for us in the next release with v1 going out. There should be round trip tests to catch this. v1 -> v1beta1 -> v1 should be lossless.

Created #3802 to track fixing this issue.

[aliok]

/close

This is done

[knative-prow-robot]

@aliok: Closing this issue.

In response to this:

/close

This is done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nlopezgi]

I think Subscription is still missing: https://github.com/knative/eventing/tree/master/pkg/reconciler/subscription. I can probably work on it if no one else is currently working on it

[aliok]

@nlopezgi

oh sorry, I thought that was done too.

I can probably work on it if no one else is currently working on it
Please take it over. Thanks!

Feel free to reopen this ticket or create a new one.

[nlopezgi]

/reopen

[knative-prow-robot]

@nlopezgi: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nlopezgi]

/close

[knative-prow-robot]

@nlopezgi: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.