Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate channel reconciler to use messaging.* v1 resources #3871

Merged
merged 4 commits into from
Aug 20, 2020
Merged

Migrate channel reconciler to use messaging.* v1 resources #3871

merged 4 commits into from
Aug 20, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Aug 18, 2020 •
edited
Loading

Part of #3584

Proposed Changes

Implementing changes according to #3789 (comment)

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 18, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestChannelStatusSubscriber/Channel_has_required_status_subscriber_fields
test/conformance.TestChannelStatusSubscriber/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelStatusSubscriber/Channel_has_required_status_subscriber_fields#02
test/conformance.TestChannelStatusSubscriber/Channel-messaging.knative.dev/v1
test/conformance.TestChannelStatusSubscriber

@matzew
Copy link
Member

matzew commented Aug 19, 2020 

test/conformance.TestChannelStatusSubscriber/Channel_has_required_status_subscriber_fields
test/conformance.TestChannelStatusSubscriber/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelStatusSubscriber/Channel_has_required_status_subscriber_fields#02
test/conformance.TestChannelStatusSubscriber/Channel-messaging.knative.dev/v1
test/conformance.TestChannelStatusSubscriber

I have seen these failing too, when I tried to set the IMC/v1 as the default channel, on the ConfigMaps (default channel, and for broker default channel)

@aliok aliok mentioned this pull request Aug 20, 2020
Closed
@aliok
Copy link
Member

aliok commented Aug 20, 2020

/test pull-knative-eventing-unit-tests

It says configmap creation timed out. Let's retry the unit tests only.

@aliok aliok mentioned this pull request Aug 20, 2020
Closed
@aliok
Copy link
Member

aliok commented Aug 20, 2020

Created a PR against @nlopezgi 's branch here for the making the code pass the conformance tests: nlopezgi#1

Tried it here: #3890

@nlopezgi can you merge that PR against your branch? then we should be good to go.

@nlopezgi
Copy link
Contributor Author

Created a PR against @nlopezgi 's branch here for the making the code pass the conformance tests: nlopezgi#1

Tried it here: #3890

@nlopezgi can you merge that PR against your branch? then we should be good to go.

Thanks a lot for catching that @aliok . Merged your changes and pushed, lets see if all tests are happy now.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/channelable_combined_types.go 93.3% 90.9% -2.4
pkg/apis/duck/v1alpha1/subscribable_types_conversion.go 89.3% 86.4% -2.8
pkg/reconciler/channel/channel.go 81.4% 77.4% -3.9

@nlopezgi nlopezgi changed the title [WIP]: New attempt to migrate channel reconciler to use messaging.* v1 resources Migrate channel reconciler to use messaging.* v1 resources Aug 20, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@nlopezgi nlopezgi mentioned this pull request Aug 20, 2020
Closed
aliok
aliok approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the great work. This was hard!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@nlopezgi
Copy link
Contributor Author

/lgtm
/approve

Thanks for the great work. This was hard!

Thank you for all the help, I was very much blocked a couple of times there and you provided the needed fixes!

matzew
matzew approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approive

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@knative-prow-robot knative-prow-robot merged commit 76bb753 into knative:master Aug 20, 2020
@nlopezgi nlopezgi mentioned this pull request Aug 25, 2020
Merged
matzew pushed a commit to matzew/eventing that referenced this pull request Aug 27, 2020
@matzew
Migrate channel reconciler to use messaging.* v1 resources (knative#3871
b621cd0 
)

* revert changes to types for v1<->v1alpha compatibility

* migrate v1beta1 -> v1 for channel reconciler

* run codegen

* merge @aliok suggested fix
@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@matzew matzew matzew approved these changes

@chizhg chizhg Awaiting requested review from chizhg

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nlopezgi @knative-test-reporter-robot @matzew @aliok @knative-metrics-robot @knative-prow-robot @googlebot