Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WaitForPodRunning instead of WaitForResourceReady on pods #4073

Closed
pierDipi opened this issue Sep 18, 2020 · 4 comments · Fixed by #4093
Closed

Use WaitForPodRunning instead of WaitForResourceReady on pods #4073

pierDipi opened this issue Sep 18, 2020 · 4 comments · Fixed by #4093
Assignees
@pierDipi
Labels
area/test-and-release Test infrastructure, tests or release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v0.18.0

Comments

@pierDipi
Copy link
Member

pierDipi commented Sep 18, 2020 •
edited
Loading

Problem

Since conformance tests cannot be run for non-channel based brokers, we copy-pasted them in https://github.com/knative-sandbox/eventing-kafka-broker, and we started to observe flaky tests.
After digging we found out that the use of WaitForResourceReady on pods makes our tests flaky, see knative-extensions/eventing-kafka-broker#183, discussion, and diff.

We should check all of our tests and use WaitForPodRunning instead of WaitForResourceReady when we're waiting for pods to be running.

Additional Info

/area test-and-release
/good-first-issue
@knative-prow-robot
Copy link
Contributor

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Expected Behavior

Since conformance tests cannot be run for non-channel based brokers, we copy-pasted them in https://github.com/knative-sandbox/eventing-kafka-broker, and we started to observe flaky tests.
After digging we found out that the use of WaitForResourceReady on pods makes our tests flaky, see knative-extensions/eventing-kafka-broker#183, discussion, and diff.

Actual Behavior

We should check all of our tests and use use WaitForPodRunning instead of WaitForResourceReady when we're waiting for pods to be running.

Additional Info

/area test-and-release
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 18, 2020
@lionelvillard
Copy link
Member

Could we also fix WaitForResourceReady to work on pods and get rid of WaitForPodRunning?

@pierDipi
Copy link
Member Author

That could be another option, but I've not identified the root cause.

@lberk lberk added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 21, 2020
@lberk lberk added this to the v0.18.0 milestone Sep 21, 2020
@pierDipi
Copy link
Member Author

/assign

@pierDipi pierDipi mentioned this issue Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierDipi pierDipi

Labels
area/test-and-release Test infrastructure, tests or release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

Use WaitForPodRunning instead of WaitForResourceReady on pods pierDipi/eventing
4 participants
@lberk @lionelvillard @pierDipi @knative-prow-robot