Use WaitForPodRunning instead of WaitForResourceReady on pods

[pierDipi]

Fixes #4073

WaitForResourceReady on pods makes our tests flaky.

Proposed Changes

• Use WaitForPodRunning instead of WaitForResourceReady on pods

Release Note

None

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

.Test
test/e2e.TestBrokerChannelFlowTriggerV1Beta1BrokerV1Beta1/Channel-messaging.knative.dev/v1beta1
test/e2e.TestBrokerChannelFlowTriggerV1Beta1BrokerV1Beta1

[pierDipi]

#3686

=== CONT  TestBrokerChannelFlowTriggerV1Beta1BrokerV1Beta1/Channel-messaging.knative.dev/v1beta1
    broker_channel_flow_helper.go:160: Failed to get the url for the channel "e2e-brokerchannel-channel": addressable does not have an Address: &{TypeMeta:{Kind:Channel APIVersion:messaging.knative.dev/v1beta1} ObjectMeta:{Name:e2e-brokerchannel-channel GenerateName: Namespace:test-broker-channel-flow-trigger-v1-beta1-broker-v1-beta1-pxk8n SelfLink:/apis/messaging.knative.dev/v1beta1/namespaces/test-broker-channel-flow-trigger-v1-beta1-broker-v1-beta1-pxk8n/channels/e2e-brokerchannel-channel UID:e3fb5c7a-0d1e-42e4-91f4-be0fd94cb19f ResourceVersion:30562 Generation:1 CreationTimestamp:2020-09-22 08:28:35 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[messaging.knative.dev/creator:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/lastModifier:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/subscribable:v1beta1] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Status:{Address:<nil>}}
        knative.dev/eventing/test/lib.(*Client).GetAddressableURI
        	/home/prow/go/src/knative.dev/eventing/test/lib/operation.go:57
        knative.dev/eventing/test/e2e/helpers.BrokerChannelFlowWithTransformation.func1
        	/home/prow/go/src/knative.dev/eventing/test/e2e/helpers/broker_channel_flow_helper.go:158
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:75
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

{
          "apiVersion": "messaging.knative.dev/v1beta1",
          "kind": "Channel",
          "metadata": {
            "annotations": {
              "messaging.knative.dev/creator": "prow-job@knative-tests.iam.gserviceaccount.com",
              "messaging.knative.dev/lastModifier": "prow-job@knative-tests.iam.gserviceaccount.com",
              "messaging.knative.dev/subscribable": "v1beta1"
            },
            "creationTimestamp": "2020-09-22T08:28:35Z",
            "generation": 1,
            "name": "e2e-brokerchannel-channel",
            "namespace": "test-broker-channel-flow-trigger-v1-beta1-broker-v1-beta1-pxk8n",
            "resourceVersion": "30571",
            "selfLink": "/apis/messaging.knative.dev/v1beta1/namespaces/test-broker-channel-flow-trigger-v1-beta1-broker-v1-beta1-pxk8n/channels/e2e-brokerchannel-channel",
            "uid": "e3fb5c7a-0d1e-42e4-91f4-be0fd94cb19f"
          },
          "spec": {
            "channelTemplate": {
              "apiVersion": "messaging.knative.dev/v1",
              "kind": "InMemoryChannel"
            }
          },
          "status": {
            "address": {
              "url": "http://e2e-brokerchannel-channel-kn-channel.test-broker-channel-flow-trigger-v1-beta1-broker-v1-beta1-pxk8n.svc.cluster.local"
            },
            "channel": {
              "apiVersion": "messaging.knative.dev/v1",
              "kind": "InMemoryChannel",
              "name": "e2e-brokerchannel-channel",
              "namespace": "test-broker-channel-flow-trigger-v1-beta1-broker-v1-beta1-pxk8n"
            },
            "conditions": [
              {
                "lastTransitionTime": "2020-09-22T08:28:44Z",
                "status": "True",
                "type": "Addressable"
              },
              {
                "lastTransitionTime": "2020-09-22T08:28:44Z",
                "status": "True",
                "type": "BackingChannelReady"
              },
              {
                "lastTransitionTime": "2020-09-22T08:28:44Z",
                "status": "True",
                "type": "Ready"
              }
            ],
            "observedGeneration": 1
          }
        }

/retest

[matzew]

/test all

[aliok]

The changes look great and they makes sense.

However, I see this comment: #4073 (comment)

What I understand from it was making the WaitForResourceReady behave similarly to WaitForPodRunning when there's a pod involved and only use WaitForResourceReady. But maybe I am wrong.

cc @lionelvillard

[aliok]

/assign

[pierDipi]

/cc @aliok
could you please take a look again?

[pierDipi]

Worked, retesting
/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-integration-tests

[aliok]

Looks great IMO.

/lgtm
/approve

Thanks!

[lionelvillard]

/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment