Add type godoc for Broker and Trigger #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmorie, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
May 27, 2021
* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test
matzew
added a commit
to matzew/eventing
that referenced
this pull request
May 27, 2021
This reverts commit 4c434bb.
cardil
added a commit
to cardil/knative-eventing
that referenced
this pull request
Jun 9, 2021
* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Jun 15, 2021
* [0.22] Backport of PRs 5321 and 4815 (from knative#1284) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of knative#5444 (knative#1286) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while combing through the API that
BrokerandTriggerdon't have type-level godoc for what they are.