-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QE] Extension point for transport used to send events in upgrade tests #4815
[QE] Extension point for transport used to send events in upgrade tests #4815
Conversation
Skipping CI for Draft Pull Request. |
…ender-extendability Conflicts fixed: * test/upgrade/prober/wathola/sender/services.go
…der-extendability Conflicts fixed: * test/upgrade/prober/wathola/sender/services.go
Codecov Report
@@ Coverage Diff @@
## main #4815 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 194 194
Lines 6006 6006
=======================================
Hits 4966 4966
Misses 717 717
Partials 323 323 Continue to review full report at Codecov.
|
…ts (knative#4815) Fixes knative#4812 - Extension point for transport used to send events in upgrade tests
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review
Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review
Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review
Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review
* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test
Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review
* Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com>
* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test
* Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com>
* [0.22] Backport of PRs 5321 and 4815 (from #1284) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of knative#5444 (#1286) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir
* Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com>
* [v0.22.0] Backport of PR 563 (use of #215) * Backport of (knative-sandbox#476) Dispatcher readiness e2e test * Parameterize Partitions created via MustCreateTopic * Add kafkaChannel creation/get obj helper functions * Add subscription scale readiness test * Add explicit t.Run statement * Move test to helper function, use channelTestRunner * Change from subscriptionv1beta1 to subscriptionv1 (abstraction prep) * Support subscription v1beta1 and v1 * Fix copyright header * Change channel creation depnding on typemeta Remove subscription v1beta1 testing, having multiple tests run at once will change the dispatcher replication in parallel * Drop unneeded parameter * Add a blank line * Fix linter complaints * Add build constraint tag to mark testing consolidated channel only * run hack/update-codegen.sh * run hack/update-codegen.sh * Modify build constraints for test * Remove v1alpha1 references as requested * Fix old reference * Change subscription creation function reference * Backport of (knative-sandbox#563) Continual tests for KafkaSource for upgrade testing * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Adding generated test images Co-authored-by: Lukas Berk <lberk@redhat.com> * Restore manually changed vendor files * Skipping subscription readiness when scaling dispatcher test (knative-sandbox#573) Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> Co-authored-by: Lukas Berk <lberk@redhat.com> Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>
[0.23] Backport of PRs 4815 5321 5444 (from knative#1309) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of (knative#5444) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir
Backport of (knative#563) * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review
* [0.23] Backport of PRs 4815 5321 5444 [0.23] Backport of PRs 4815 5321 5444 (from #1309) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of (knative#5444) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir * Revert "Update deps"
* [QE] Continual tests for KafkaSource for upgrade testing Backport of (knative#563) * Using knative/eventing#4815 to override wathola sender transport * Actual way of replacing an image used for wathola sender * Reformatting * Wathola Kafka Sender utilizing plain connection * Implementing SUT and custom sender * KafkaSource upgrade test * Update knative-eventing to 8270497041f2 * Using source config template * Export kafkaTopicEndpoint to be able to read on TOML * wathola config reader can read both string and map[string]interface{} for sender.address * KafkaSource upgrade test works * Allow to influence Kafka cluster connection details * Channel tests working * Removing unused variable name * Review knative/eventing#5321 changes * Updates after review of knative/eventing#4815 * Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit * Update deps * Update deps * Refactor after review * Shorten the TypeMeta field * Tweak the merge slices func after review * Add wathola-kafka-sender test image * update pkg * Revert "update deps" * Remove the interim personal fork
Fixes #4812
Proposed Changes