[0.22] Backport of PRs 4815 5321 5444 #1309
Conversation
* Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test
* Don't wait on triggers, before deploying their subscriber
openshift-ci
bot
added
the
area/test-and-release
|
/hold I'll try to verify this on serverless operator before merging |
openshift-ci
bot
added
the
do-not-merge/hold
|
Hi what happened at the old vendor dir, I am missing a bit of the context here. |
|
@skonto I don't understand your question. Could you rephrase it? |
|
@skonto There were some PRs like #1302 or #1282 that directly modifies the vendor directory without changing See, a mailing thread on #serverless-dev about it: "Adding CI checks on OpenShift knative forks" |
|
Here's a passing build on serverless operator with those changes: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_serverless-operator/1011/pull-ci-openshift-knative-serverless-operator-main-4.7-upgrade-tests-aws-ocp-47/1402743138010796032 /unhold Please review |
openshift-ci
bot
removed
the
do-not-merge/hold
Based on the above passed build for serverless, LGTM /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
* [0.23] Backport of PRs 4815 5321 5444 [0.23] Backport of PRs 4815 5321 5444 (from #1309) * Backport of (knative#4815) Extension point for transport used to send events in upgrade tests * EventSender interface to enable customisation of sending events * Clean ups * Basic extendability of wathola sender * Updating boilerplate * Testing sender services * Allow of customization of wathola test images on downstream * Waiting until test port is open * Switch to v2 of pelletier/toml to support reading string/map[string]interface{} for interface{} typed field. * LogLevel is settable * Logging received event * Changes after review * Backport of (knative#5321) Allow to change SUT for upgrade tests * Introduction of SUT package * Refactor to keep used interfaces and deprecate them first * Update-codegen * Restoring configuration options, to have Deprecated status instead * Working e2e test * Fixing NPE in upgrade tests * Introducing new interfaces for configuration and easy execution * NPE fix in continual.go@55 * Removal of ensure.NoError * Raising UnavailablePeriodToReport to 10s to make tests more stable * Running all e2e tagged tests * Raising unavailibility period to 60s as load & retries makes it longer. * Execute upgrade e2e tests with additional run * Using SutURL in wathola config instead of BrokerURL * Removal of redundant namespace option * Switch to using interface{} as endpoint address representation * Fixing compile error on prober * Use full event type only * Remove unused event prefix * Renaming after code review * Removal of unnecessary github.com/prometheus/common * Remove Kafka from README and SUT to graph * Remove unused EventsTypePrefix option * Remove execution of TestBrokerAndTriggers helper test * Backport of (knative#5444) * Don't wait on triggers, before deploying their subscriber * Restore manually modified vendor dir * Revert "Update deps"
[0.22] Backport of PRs:
Restoring manually modified vendor dir with: 481a26f