Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor dependency on serving and build #319

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Remove vendor dependency on serving and build #319

merged 3 commits into from
Aug 6, 2018

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Aug 3, 2018

The istio client has moved to knative/pkg, we can depend on that without
needing to vendor the remainder of knative/serving. The knative/build
dependency was effectively unused.

This PR needs to be updated once knative/pkg#35 is merged.

Refs knative/pkg#1

/hold
/assign @tcnghia

Proposed Changes

  • use Istio types and clients vendored from knative/pkg
  • drop dependency on knative/serving
  • drop dependency on knative/build

@scothis
Remove vendor dependency on serving and build
ab17e4e 
The istio client has moved to knative/pkg, we can depend on that without
needing to vendor the remainder of knative/serving. The knative/build
dependency was effectively unused.

Refs: knative/pkg#1
@google-prow-robot google-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: scothis
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vaikas-google

If they are not already assigned, you can assign the PR to them by writing /assign @vaikas-google in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 3, 2018
@scothis scothis mentioned this pull request Aug 3, 2018
Merged
@n3wscott
Copy link
Contributor

n3wscott commented Aug 3, 2018

#276 depends on Serving.

@scothis
Copy link
Contributor Author

scothis commented Aug 3, 2018

/test pull-knative-eventing-integration-tests

@google-prow-robot
Copy link

@scothis: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-integration-tests ab17e4e link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@scothis
Copy link
Contributor Author

scothis commented Aug 3, 2018

/test pull-knative-eventing-integration-tests

1 similar comment
@scothis
Copy link
Contributor Author

scothis commented Aug 3, 2018

/test pull-knative-eventing-integration-tests

@scothis
Update to a proper knative/pkg refspec
ec4c7d3 
Also updated names of istio* to shared* where appropriate.
@scothis
Copy link
Contributor Author

scothis commented Aug 3, 2018

Updated to a merged commit for knative/pkg

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2018
@scothis
Copy link
Contributor Author

scothis commented Aug 3, 2018

/assign @mattmoor

@scothis
Copy link
Contributor Author

scothis commented Aug 4, 2018

/test pull-knative-eventing-integration-tests
/test pull-knative-eventing-go-coverage

@scothis
Copy link
Contributor Author

scothis commented Aug 6, 2018

/test pull-knative-eventing-integration-tests

@scothis
Copy link
Contributor Author

scothis commented Aug 6, 2018

@mattmoor PTAL

@mattmoor
Copy link
Member

mattmoor commented Aug 6, 2018

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, scothis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2018
@knative-prow-robot knative-prow-robot merged commit 8043ed8 into knative:master Aug 6, 2018
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 23, 2019
@openshift-merge-robot
Merge pull request knative#319 from matzew/080_triuggers
ff0d8ca 
🤖 CI was here...🔥
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@inlined inlined Awaiting requested review from inlined

Assignees

@tcnghia tcnghia

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@scothis @google-prow-robot @n3wscott @mattmoor @knative-prow-robot @tcnghia