Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Istio CRD types and client here #1

Closed
scothis opened this issue Jul 25, 2018 · 2 comments
Closed

Move Istio CRD types and client here #1

scothis opened this issue Jul 25, 2018 · 2 comments
Assignees
@scothis
Labels
area/networking

Comments

@scothis
Copy link
Contributor

scothis commented Jul 25, 2018

Serving currently contains CRD types and client for Istio. This is also used by eventing and should be moved here to further decouple eventing from serving.

https://github.com/knative/serving/tree/master/pkg/apis/istio
@mattmoor
Copy link
Member

/area networking

@scothis
Copy link
Contributor Author

scothis commented Aug 2, 2018

/assign @scothis

scothis added a commit to scothis/pkg that referenced this issue Aug 2, 2018
@scothis
Add Istio client from knative/serving
7a05c83 
- Add Istio types in 'apis/istio/v1alpha3'
- Update codegen scripts
- Generate client in 'client'
- Add @tcnghia as owner for 'apis/istio'

Fixes knative#1
@scothis scothis mentioned this issue Aug 2, 2018
Merged
scothis added a commit to scothis/pkg that referenced this issue Aug 3, 2018
@scothis
Add Istio client from knative/serving
5f82623 
- Add Istio types in 'apis/istio/v1alpha3'
- Update codegen scripts
- Generate client in 'client'
- Add @tcnghia as owner for 'apis/istio'

Fixes knative#1
scothis added a commit to scothis/serving that referenced this issue Aug 3, 2018
@scothis
Use knative/pkg for Istio types and client
71d5a39 
knative/pkg#1
@scothis scothis mentioned this issue Aug 3, 2018
Merged
scothis added a commit to scothis/eventing that referenced this issue Aug 3, 2018
@scothis
Remove vendor dependency on serving and build
ab17e4e 
The istio client has moved to knative/pkg, we can depend on that without
needing to vendor the remainder of knative/serving. The knative/build
dependency was effectively unused.

Refs: knative/pkg#1
@scothis scothis mentioned this issue Aug 3, 2018
Merged
knative-prow-robot pushed a commit that referenced this issue Aug 3, 2018
@scothis @knative-prow-robot
Add Istio client from knative/serving (#35)
a088fee 
* Add Istio client from knative/serving

- Add Istio types in 'apis/istio/v1alpha3'
- Update codegen scripts
- Generate client in 'client'
- Add @tcnghia as owner for 'apis/istio'

Fixes #1

* nix linguring serving package dep

* cleanup vendor cache

* Mark /client as generated

* Fix verify-codegen script

* Run verify-codegen.sh via presubmit-tests.sh

* Remove Gatewaies -> Gateway hack

Looks like we don't need it anymore
knative-prow-robot pushed a commit to knative/serving that referenced this issue Aug 6, 2018
@scothis @knative-prow-robot
Use knative/pkg for Istio types and client (#1799)
7d86975 
* Use knative/pkg for Istio types and client

knative/pkg#1

* Rename istioClient to sharedClient

...and other istio* names to shared* where appropriate

* Use proper refspec for github.com/knative/pkg
knative-prow-robot pushed a commit to knative/eventing that referenced this issue Aug 6, 2018
@scothis @knative-prow-robot
Remove vendor dependency on serving and build (#319)
8043ed8 
* Remove vendor dependency on serving and build

The istio client has moved to knative/pkg, we can depend on that without
needing to vendor the remainder of knative/serving. The knative/build
dependency was effectively unused.

Refs: knative/pkg#1

* Update to a proper knative/pkg refspec

Also updated names of istio* to shared* where appropriate.

* Fix nil pointer dereference
knative-prow bot pushed a commit that referenced this issue Apr 25, 2022
@cardil @evankanderson
🐛 TestDialWithBackoff work without special environment (#2402)
45c37c2 
* Making TestDialWithBackoff work without special environment

* Use listen to force a connection timeout (#1)

* Don't parallelize tests to avoid free port conflicts

Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scothis scothis

Labels
area/networking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scothis @mattmoor @google-prow-robot