-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest controller-runtime #335
Conversation
Revision 60bb251. Improves logging and adds option to set resync period.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: grantr If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
I think you should add an entry into the Gopkg.toml file to call out a release version so the dep ensure call can be deterministic. |
I'm pretty sure For example, 8043ed8 updated Gopkg.lock by removing the serving dependency and adding the knative/pkg dependency. That run of Based on that evidence, I prefer not to add constraints to Gopkg.toml when there is no practical constraint to enforce. |
/assign @evankanderson |
Superseded by #344. |
remoive helloworld
Revision 60bb251. Improves logging and adds option to set resync period to something other than 10 hours.