Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest controller-runtime #335

Closed
wants to merge 1 commit into from

Conversation

grantr
Copy link
Contributor

@grantr grantr commented Aug 8, 2018

Revision 60bb251. Improves logging and adds option to set resync period to something other than 10 hours.

Revision 60bb251. Improves logging and adds option to set resync
period.
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grantr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vaikas-google

If they are not already assigned, you can assign the PR to them by writing /assign @vaikas-google in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2018
@grantr
Copy link
Contributor Author

grantr commented Aug 9, 2018

/retest

@n3wscott
Copy link
Contributor

n3wscott commented Aug 9, 2018

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2018
@n3wscott
Copy link
Contributor

n3wscott commented Aug 9, 2018

I think you should add an entry into the Gopkg.toml file to call out a release version so the dep ensure call can be deterministic.

@grantr
Copy link
Contributor Author

grantr commented Aug 9, 2018

I'm pretty sure dep ensure is always deterministic unless a new directive is added to Gopkg.toml or dep ensure -update is used (as in this case).

For example, 8043ed8 updated Gopkg.lock by removing the serving dependency and adding the knative/pkg dependency. That run of dep ensure did not update the controller-runtime dependency, even though an update was available. The controller-runtime dependency has never been updated since it was introduced in 55f2235.

Based on that evidence, I prefer not to add constraints to Gopkg.toml when there is no practical constraint to enforce.

@grantr
Copy link
Contributor Author

grantr commented Aug 9, 2018

/assign @evankanderson

@grantr
Copy link
Contributor Author

grantr commented Aug 14, 2018

Superseded by #344.

@grantr grantr closed this Aug 14, 2018
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants