Updating to k8s 1.11. #344
Conversation
knative-prow-robot
added
the
size/XXL
|
/assign @mattmoor Matt did similar work for pkg and serving. |
|
Depends on kubernetes-sigs/controller-runtime#108 |
n3wscott
force-pushed
the
update-dep-kube-pkg
branch
from
8fc4695 to
54e6dd5
Compare
|
I updated controller-runtime to k8s 1.11 and will use my fork as a dep for now until the kubebuilder team is able to update both kubebuilder and controller-runtime. |
|
/lgtm |
|
The e2e test seems to be blocked by #345 |
|
e2e test is not blocked, it just flaked on istio. It gets just a warn from #345 /test pull-knative-eventing-integration-tests |
|
/test pull-knative-eventing-integration-tests |
|
closes #335 |
n3wscott
force-pushed
the
update-dep-kube-pkg
branch
from
550918b to
b2a8d38
Compare
|
I found a real issue in my patch of moving controller-runtime to k8s 1.11. I fixed this on my fork, pulling that change in now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
* Updating to k8s 1.11. * Forgot the new vendored code. * Update controller-runtime to k8s 1.11. * Ran update-codegen. * Update to Resource.Resource. There was an issue fixed in controller-runtime fork. * Action needs a namespace now. * should not have to set this namespace, revert. * Lost the namespace on the dynamic client for flows, adding back. * Looks like it was not a set namespace method, but returns a new obj. Really use it this time.
knative serving and pkg have moved on to k8s 1.11 clients. If we would like to get new pkg features, we need to move on too.
I updated controller-runtime to k8s 1.11 and will use my fork as a dep for now until the kubebuilder team is able to update both kubebuilder and controller-runtime.
See kubernetes-sigs/controller-runtime#108