Do not fail when subscription already exists #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we added a workaround for EOF errors: we try to create a subscription multiple times when it already exists. Some test runs show errors like this: ``` creation.go:175: Creating v1 subscription creation.go:180: Failed to create subscription "<name>": conversion webhook for messaging.knative.dev/v1beta1, Kind=Subscription failed: Post https://eventing-webhook.knative-eventing-aw90d392a6.svc:443/resource-conversion?timeout=30s: EOF creation.go:175: Creating v1 subscription <name> for channel &TypeMeta{Kind:InMemoryChannel,APIVersion:messaging.knative.dev/v1,}-e2e-singleevent-channel-structured creation.go:180: Failed to create subscription "<name>": subscriptions.messaging.knative.dev "e2e-singleevent-subscription-structured" already exists creation.go:185: Failed to create subscription "<name>": subscriptions.messaging.knative.dev "e2e-singleevent-subscription-structured" already exists ``` So, this PR adds a check for already exists errors to avoid failing tests in those cases. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
added
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we added a workaround for EOF errors:
#3681 and some tests seem to be flaky because
we try to create a subscription multiple times when
it already exists.
Some test runs show errors like this:
So, this PR adds a check for already exists errors to
avoid failing tests in those cases.
Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com
Addresses #3653
Proposed Changes