[release-1.7] Properly export trace for duplicated "finished" event #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with duplicated finished event in which case the following error was thrown: knative.dev/eventing/test/upgrade/prober.(*prober).getStepNoFromMsg ... panic: runtime error: index out of range [1] with length 0
5 tasks
knative-prow
bot
added
area/test-and-release
Codecov ReportBase: 81.96% // Head: 81.96% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## release-1.7 #6540 +/- ##
============================================
Coverage 81.96% 81.96%
============================================
Files 235 235
Lines 11726 11726
============================================
Hits 9611 9611
Misses 1644 1644
Partials 471 471 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Dec 23, 2022
…native#6540) * Properly export trace for duplicated "finished" event Fixes an issue with duplicated finished event in which case the following error was thrown: knative.dev/eventing/test/upgrade/prober.(*prober).getStepNoFromMsg ... panic: runtime error: index out of range [1] with length 0 * Define FinishedEventPrefix and reuse it Co-authored-by: Martin Gencur <mgencur@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Dec 23, 2022
…native#6540) (#62) * Properly export trace for duplicated "finished" event Fixes an issue with duplicated finished event in which case the following error was thrown: knative.dev/eventing/test/upgrade/prober.(*prober).getStepNoFromMsg ... panic: runtime error: index out of range [1] with length 0 * Define FinishedEventPrefix and reuse it Co-authored-by: Martin Gencur <mgencur@redhat.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Martin Gencur <mgencur@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6536