[release-1.7] Properly export trace for duplicated "finished" event #62
Conversation
…native#6540) * Properly export trace for duplicated "finished" event Fixes an issue with duplicated finished event in which case the following error was thrown: knative.dev/eventing/test/upgrade/prober.(*prober).getStepNoFromMsg ... panic: runtime error: index out of range [1] with length 0 * Define FinishedEventPrefix and reuse it Co-authored-by: Martin Gencur <mgencur@redhat.com>
|
/cherry-pick release-v1.8 |
|
@matzew: once the present PR merges, I will cherry-pick it on top of release-v1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@matzew: new pull request could not be created: failed to create pull request against openshift-knative/eventing#release-v1.8 from head openshift-cherrypick-robot:cherry-pick-62-to-release-v1.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift-knative:release-v1.8 and openshift-cherrypick-robot:cherry-pick-62-to-release-v1.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@matzew I think you need to check this manually when you're back. I mean, why the cherry pick fails |
Backport of upstream knative#6540