Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness and liveness probes in controller #6566

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

lionelvillard
Copy link
Member

Partial fix for knative/pkg#1048

Having both readiness and liveness probes is good kube practice.

For now the implementation relies on a simple http server we can improve later as needed.

Proposed Changes

  • 🎁 Add readiness and liveness probes in Knative Eventing controller

Pre-review Checklist

  • [x ] At least 80% unit test coverage
  • [x ] E2E tests for any new behavior
  • [x ] Docs PR for any user-facing impact
  • [ x] Spec PR for any new API feature
  • [x ] Conformance test for any change to the spec

Release Note

 :gift: Add readiness and liveness probes in Knative Eventing controller

Docs

@knative-prow
Copy link

knative-prow bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2022
@cr22rc
Copy link
Contributor

cr22rc commented Oct 12, 2022

/LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@lionelvillard
Copy link
Member Author

/test upgrade-tests

1 similar comment
@lionelvillard
Copy link
Member Author

/test upgrade-tests

@knative-prow knative-prow bot merged commit 801a8e6 into knative:main Oct 12, 2022
@lionelvillard
Copy link
Member Author

/cherry-pick release-1.6

@lionelvillard
Copy link
Member Author

/cherry-pick release-1.5

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #6567

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #6568

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member

matzew commented Oct 14, 2022

@lionelvillard what's against also bringing this to 1.7 ? 😅

@lionelvillard
Copy link
Member Author

/cherry-pick release-1.7

thanks @matzew !

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #6570

In response to this:

/cherry-pick release-1.7

thanks @matzew !

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants