-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readiness and liveness probes in controller #6566
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/LGTM |
/test upgrade-tests |
1 similar comment
/test upgrade-tests |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
@lionelvillard: new pull request created: #6567 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lionelvillard: new pull request created: #6568 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lionelvillard what's against also bringing this to 1.7 ? 😅 |
/cherry-pick release-1.7 thanks @matzew ! |
@lionelvillard: new pull request created: #6570 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Partial fix for knative/pkg#1048
Having both readiness and liveness probes is good kube practice.
For now the implementation relies on a simple http server we can improve later as needed.
Proposed Changes
Pre-review Checklist
Release Note
Docs