Add missing deployment probes #13563

skonto · 2022-12-19T12:18:50Z

partially fixes knative/pkg#1048 for now.

Proposed Changes

Adds probes to deployments that don't have them. Webhooks call drain so no need. Activator, autoscaler have already.
Similar to Add readiness and liveness probes in controller eventing#6566
Asked also here Controller has no livenessProbe and readinessProbe #13430
It can be moved to knative.pkg for generic use if we want to.

Release Note

Controllers now have liveness and readiness probes

codecov · 2022-12-19T12:26:01Z

Codecov Report

Base: 86.19% // Head: 86.19% // No change to project coverage 👍

Coverage data is based on head (9afed75) compared to base (8c282ba).
Patch has no changes to coverable lines.

❗ Current head 9afed75 differs from pull request most recent head f69f7cc. Consider uploading reports for the commit f69f7cc to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13563   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         197      197           
  Lines       14775    14775           
=======================================
  Hits        12736    12736           
  Misses       1736     1736           
  Partials      303      303

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

skonto · 2022-12-19T14:32:31Z

/retest

skonto · 2022-12-19T14:53:01Z

Failures seem irrelevant:

jq: error (at <stdin>:1): Cannot index string with string "tag_name"```

skonto · 2022-12-20T09:45:19Z

@dprotaso @psschwei gentle ping

dprotaso

It seems like the intent of the linked issue was to add this logic to the sharedmain package - why not make the necessary changes in knative/pkg ?

dprotaso · 2023-01-17T22:13:24Z

cmd/default-domain/main.go

@@ -226,5 +219,4 @@ func main() {
 	}

 	logger.Info("Updated default domain to: ", domain)
-	server.Shutdown(context.Background())


Shutdown was blocking before and now it's not. This means main will exit and run defer's etc.

Ah yes, correct will fix. Just need to block on the context: <-ctx.Done() or something.

skonto · 2023-01-18T09:29:54Z

Ok I will move the logic in the knative/pkg I agree it would be useful there and then update the PR here to test it.

dprotaso · 2023-01-18T19:33:01Z

/hold

evankanderson · 2023-01-24T00:08:07Z

(When you update pkg, can you reference this PR, so we can track when this should be revised?)

skonto · 2023-02-17T11:34:28Z

@dprotaso gentle ping, this should be quick.

skonto · 2023-02-20T08:34:00Z

@dprotaso @evankanderson gentle ping.

evankanderson

/lgtm
/approve

knative-prow · 2023-02-20T15:51:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

skonto · 2023-02-20T15:54:26Z

@dprotaso is it ok to unhold?

skonto · 2023-02-21T08:32:05Z

@dprotaso gentle ping.

dprotaso · 2023-03-06T22:22:27Z

/unhold

/lgtm thanks

* add probes to all deployments (#176) * add missing probes (knative#13563) * Bump manifests --------- Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>

* add probes to all deployments (#176) * add missing probes (knative#13563) * Bump manifests --------- Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>

knative-prow bot requested review from carlisia, nader-ziada and whaught December 19, 2022 12:18

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/autoscale labels Dec 19, 2022

skonto force-pushed the add_missing_probes branch 3 times, most recently from 2b1a805 to c8a61fd Compare December 19, 2022 13:45

dprotaso reviewed Jan 17, 2023

View reviewed changes

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023

skonto mentioned this pull request Jan 26, 2023

Add health checks knative/pkg#2671

Merged

skonto force-pushed the add_missing_probes branch from c8a61fd to acbb5db Compare January 26, 2023 13:25

skonto changed the title ~~Add missing deployment probes~~ [wip] Add missing deployment probes Jan 26, 2023

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2023

skonto force-pushed the add_missing_probes branch 2 times, most recently from 8c6c986 to e89fd48 Compare February 8, 2023 15:23

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023

skonto force-pushed the add_missing_probes branch from cc42e6b to c1b15ad Compare February 15, 2023 14:04

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2023

skonto force-pushed the add_missing_probes branch from c1b15ad to 9afed75 Compare February 17, 2023 10:20

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2023

skonto changed the title ~~[wip] Add missing deployment probes~~ Add missing deployment probes Feb 17, 2023

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023

add missing probes

f69f7cc

skonto force-pushed the add_missing_probes branch from 9afed75 to f69f7cc Compare February 17, 2023 10:42

evankanderson reviewed Feb 20, 2023

View reviewed changes

knative-prow bot assigned evankanderson Feb 20, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023

skonto mentioned this pull request Feb 21, 2023

[release-v1.7][SRVKS-999] Add probes to all deployments openshift-knative/serving#176

Merged

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2023

knative-prow bot merged commit 587f587 into knative:main Mar 6, 2023

nak3 pushed a commit to nak3/serving that referenced this pull request Mar 8, 2023

add missing probes (knative#13563)

330019f

nak3 mentioned this pull request Mar 8, 2023

[release-v1.8] add probes to all deployments openshift-knative/serving#199

Merged

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-serving that referenced this pull request Mar 8, 2023

add missing probes (knative#13563)

59bfcb3

dprotaso mentioned this pull request Mar 29, 2023

Controller has no livenessProbe and readinessProbe #13430

Closed

skonto mentioned this pull request Apr 14, 2023

Deployment probe fixes #13885

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing deployment probes #13563

Add missing deployment probes #13563

skonto commented Dec 19, 2022 •

edited by dprotaso

Loading

codecov bot commented Dec 19, 2022 •

edited

Loading

skonto commented Dec 19, 2022

skonto commented Dec 19, 2022 •

edited

Loading

skonto commented Dec 20, 2022

dprotaso left a comment

dprotaso Jan 17, 2023

skonto Jan 18, 2023 •

edited

Loading

skonto commented Jan 18, 2023

dprotaso commented Jan 18, 2023

evankanderson commented Jan 24, 2023

skonto commented Feb 17, 2023

skonto commented Feb 20, 2023 •

edited

Loading

evankanderson left a comment

knative-prow bot commented Feb 20, 2023

skonto commented Feb 20, 2023

skonto commented Feb 21, 2023

dprotaso commented Mar 6, 2023

Add missing deployment probes #13563

Add missing deployment probes #13563

Conversation

skonto commented Dec 19, 2022 • edited by dprotaso Loading

Proposed Changes

Release Note

codecov bot commented Dec 19, 2022 • edited Loading

Codecov Report

skonto commented Dec 19, 2022

skonto commented Dec 19, 2022 • edited Loading

skonto commented Dec 20, 2022

dprotaso left a comment

Choose a reason for hiding this comment

dprotaso Jan 17, 2023

Choose a reason for hiding this comment

skonto Jan 18, 2023 • edited Loading

Choose a reason for hiding this comment

skonto commented Jan 18, 2023

dprotaso commented Jan 18, 2023

evankanderson commented Jan 24, 2023

skonto commented Feb 17, 2023

skonto commented Feb 20, 2023 • edited Loading

evankanderson left a comment

Choose a reason for hiding this comment

knative-prow bot commented Feb 20, 2023

skonto commented Feb 20, 2023

skonto commented Feb 21, 2023

dprotaso commented Mar 6, 2023

skonto commented Dec 19, 2022 •

edited by dprotaso

Loading

codecov bot commented Dec 19, 2022 •

edited

Loading

skonto commented Dec 19, 2022 •

edited

Loading

skonto Jan 18, 2023 •

edited

Loading

skonto commented Feb 20, 2023 •

edited

Loading