Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CLI deps (cobra, viper, etc) #1326

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

lkingland
Copy link
Member

  • 🧹 updates viper, cobra etc

Includes bugfixes to parsing environment variables vs flags into string arrays. Used in the forthcoming Global Config: Functipn Context feature.

Related: #901

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 47.59% // Head: 49.45% // Increases project coverage by +1.85% 🎉

Coverage data is based on head (885f98d) compared to base (a74e825).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   47.59%   49.45%   +1.85%     
==========================================
  Files          74       77       +3     
  Lines       10415    10541     +126     
==========================================
+ Hits         4957     5213     +256     
+ Misses       5036     4886     -150     
- Partials      422      442      +20     
Flag Coverage Δ
integration-tests 43.96% <ø> (?)
unit-tests ?
unit-tests-macos-latest 46.09% <ø> (?)
unit-tests-ubuntu-latest 47.59% <ø> (?)
unit-tests-windows-latest 46.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
openshift/metadata.go 0.00% <0.00%> (ø)
openshift/openshift.go 5.76% <0.00%> (ø)
client.go 65.18% <0.00%> (+0.60%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
k8s/secrets.go 19.58% <0.00%> (+6.18%) ⬆️
k8s/configmaps.go 50.00% <0.00%> (+15.78%) ⬆️
k8s/client.go 88.46% <0.00%> (+23.07%) ⬆️
docker/docker_client.go 83.19% <0.00%> (+23.52%) ⬆️
k8s/dialer.go 74.06% <0.00%> (+74.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lkingland lkingland marked this pull request as ready for review October 14, 2022 00:05
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2022
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3a99f1f into knative:main Oct 14, 2022
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@lkingland lkingland deleted the lkingland/update-cli-deps branch March 6, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants