Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config dir default empty #1376

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Oct 21, 2022

🐛 fix incorrect default config directory
🐛 add a clean home setup to a test

When the system can not automatically determine a determine a config directory path, it should communicate this by returning the zero value, letting the caller handle the situation accordingly (skip usage, or create a temporary home directory)

/kind bug

Related: #901

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2022
@lkingland lkingland marked this pull request as ready for review October 21, 2022 16:15
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 53.50% // Head: 62.20% // Increases project coverage by +8.70% 🎉

Coverage data is based on head (3bcc66c) compared to base (3665769).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   53.50%   62.20%   +8.70%     
==========================================
  Files          72       75       +3     
  Lines       10477    10598     +121     
==========================================
+ Hits         5606     6593     +987     
+ Misses       4443     3449     -994     
- Partials      428      556     +128     
Flag Coverage Δ
integration-tests 51.88% <100.00%> (?)
unit-tests-macos-latest 52.05% <100.00%> (?)
unit-tests-ubuntu-latest 53.48% <100.00%> (?)
unit-tests-windows-latest 52.07% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/config.go 94.54% <100.00%> (-0.46%) ⬇️
openshift/openshift.go 5.76% <0.00%> (ø)
openshift/metadata.go 0.00% <0.00%> (ø)
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 63.75% <0.00%> (+0.62%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
k8s/secrets.go 19.58% <0.00%> (+6.18%) ⬆️
k8s/configmaps.go 50.00% <0.00%> (+15.78%) ⬆️
k8s/client.go 88.46% <0.00%> (+23.07%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+25.21%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@knative-prow knative-prow bot merged commit ffa0a4b into knative:main Oct 21, 2022
@lkingland lkingland added this to the 1.9.0 Release milestone Nov 22, 2022
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@lkingland lkingland deleted the lkingland/config-dir-default branch March 6, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants