Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deploy cmd namespace #1390

Merged
merged 2 commits into from
Oct 31, 2022
Merged

chore: deploy cmd namespace #1390

merged 2 commits into from
Oct 31, 2022

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Oct 31, 2022 •
edited
Loading

  • 🧹 separates namespace warnings from derivation logic
  • 🧹 tests cleanup and simplification
  • 🧹 integrates deploy namespace value derivation with flag init flow

Preparatory cleanup for switch to use Global Config namespace value when available.

/kind cleanup
Related: #901

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited
Loading

Codecov Report

Base: 61.85% // Head: 61.85% // No change to project coverage 👍

Coverage data is based on head (0fa9359) compared to base (0fa9359).
Patch has no changes to coverable lines.

❗ Current head 0fa9359 differs from pull request most recent head 706d95c. Consider uploading reports for the commit 706d95c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1390   +/-   ##
=======================================
  Coverage   61.85%   61.85%           
=======================================
  Files          74       74           
  Lines       10616    10616           
=======================================
  Hits         6566     6566           
  Misses       3493     3493           
  Partials      557      557
Flag Coverage Δ
integration-tests 51.82% <0.00%> (ø)
unit-tests 53.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lkingland lkingland force-pushed the lkingland/deploy-cmd-namespace branch from 756833e to 3c9a6db Compare October 31, 2022 14:44
@lkingland lkingland changed the title [WIP] chore: deploy cmd namespace simplification chore: deploy cmd namespace Oct 31, 2022
@lkingland lkingland marked this pull request as ready for review October 31, 2022 14:45
@knative-prow knative-prow bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2022
@lkingland
chore: deploy namespace simplification
bad2113 
Separates namespace redeploy warnings from namespace value derivation
logic.  Simplifies derivation by integration more closely with flag init
flow.
@lkingland
cleanup
706d95c
@lkingland lkingland force-pushed the lkingland/deploy-cmd-namespace branch from 3d3f93f to 706d95c Compare October 31, 2022 18:22
@lkingland lkingland added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 31, 2022
@matejvasek
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2edb259 into knative:main Oct 31, 2022
@lkingland lkingland added this to the 1.9.0 Release milestone Nov 22, 2022
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@lkingland @lance
chore: deploy cmd namespace (knative#1390)
b8afb67 
* chore: deploy namespace simplification

Separates namespace redeploy warnings from namespace value derivation
logic.  Simplifies derivation by integration more closely with flag init
flow.

* cleanup
@lkingland lkingland deleted the lkingland/deploy-cmd-namespace branch March 6, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Functions WG Roadmap
Archived in project
Milestone
1.9.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@lkingland @matejvasek