Use current (as in PR) func image in integration tests #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportBase: 51.33% // Head: 61.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 51.33% 61.19% +9.86%
==========================================
Files 71 74 +3
Lines 9812 10152 +340
==========================================
+ Hits 5037 6213 +1176
+ Misses 4225 3368 -857
- Partials 550 571 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/cc @jrangelramos |
matejvasek
requested review from
zroubalik,
lance and
lkingland
and removed request for
nainaz
|
/lgtm |
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
matejvasek
force-pushed
the
fix-test-func-image
branch
from
3eec3b0 to
212aa0e
Compare
|
@lance @jrangelramos please re-lgtm. |
|
/lgtm |
lance
pushed a commit
to lance/func
that referenced
this pull request
Feb 15, 2023
* cleanup: style Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: use current func image for in cluster tests Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
lance
pushed a commit
to lance/func
that referenced
this pull request
Feb 21, 2023
* cleanup: style Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: use current func image for in cluster tests Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
* feat: enabled s2i for python (#1562) * feat: enable s2i for python Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com> * Use current (as in PR) func image in integration tests (#1548) * cleanup: style Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: use current func image for in cluster tests Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com> Co-authored-by: Matej Vasek <mvasek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
funcin Tekton task during integration testing.Without this change the
funcfrommainis used and changes in PR are not tested for on cluster build.