feat: enabled s2i for python

[matejvasek]

Changes

• 🎁 Enabled s2i build for Python functions.

feat: enabled s2i for python functions

[codecov]

Codecov Report

Base: 60.20% // Head: 49.42% // Decreases project coverage by -10.79% ⚠️

Coverage data is based on head (ae31e6c) compared to base (b02956b).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1562       +/-   ##
===========================================
- Coverage   60.20%   49.42%   -10.79%     
===========================================
  Files          75       73        -2     
  Lines       10237    10103      -134     
===========================================
- Hits         6163     4993     -1170     
- Misses       3503     4687     +1184     
+ Partials      571      423      -148     

Flag	Coverage Δ
integration-tests	?
unit-tests	?
unit-tests-windows-latest	49.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/builders/s2i/builder.go	61.33% <ø> (+1.33%)	⬆️
pkg/k8s/security_context.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/knative/logs.go	0.00% <0.00%> (-84.54%)	⬇️
pkg/k8s/dialer.go	0.00% <0.00%> (-73.44%)	⬇️
pkg/k8s/persistent_volumes.go	0.00% <0.00%> (-72.40%)	⬇️
pkg/k8s/logs.go	0.00% <0.00%> (-70.00%)	⬇️
pkg/knative/describer.go	0.00% <0.00%> (-66.18%)	⬇️
pkg/knative/lister.go	0.00% <0.00%> (-64.92%)	⬇️
pkg/knative/deployer.go	6.16% <0.00%> (-56.72%)	⬇️
pkg/knative/client.go	0.00% <0.00%> (-53.85%)	⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jrangelramos]

/lgtm
/hold for others to verify

[zroubalik]

Looking good! Could you please also enable e2e tests for this? https://github.com/knative/func/blob/main/test/oncluster/scenario_runtime_test.go#L21

[matejvasek]

@lance @zroubalik @jrangelramos PTAL

[matejvasek]

@lance could you please override codecov/project ? The coverage upload is flaking.

[lance]

/override codecov/project

[knative-prow]

@lance: Overrode contexts on behalf of lance: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance]

/lgtm
Thanks @matejvasek!

[zroubalik]

/lgtm

awesome!

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

/unhold

[lance]

/cherry-pick release-1.9

[knative-prow-robot]

@lance: #1562 failed to apply on top of branch "release-1.9":

Applying: feat: enable s2i for python
Using index info to reconstruct a base tree...
A	generate/zz_filesystem_generated.go
A	pkg/builders/s2i/builder.go
Falling back to patching base and 3-way merge...
Auto-merging s2i/builder.go
CONFLICT (modify/delete): generate/zz_filesystem_generated.go deleted in HEAD and modified in feat: enable s2i for python. Version feat: enable s2i for python of generate/zz_filesystem_generated.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: enable s2i for python
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.