Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global config cli #1622

Closed
wants to merge 2 commits into from
Closed

feat: global config cli #1622

wants to merge 2 commits into from

Conversation

lkingland
Copy link
Member

**** Please note this PR is currently still a Work In Progress ****

Changes

  • 🎁 Adds Global System Configuration via func config [get|set|unset|list] commands

Taking place of the commands promoted up one level in #1620 (git,volumes, labels etc) is a new config subcommand which is specifically for Global Config default settings. See #1620 for a discussion of the reasoning behind promoting the metadata commands to the root and repurposing the config subcommand to be dedicated to global defaults.

/kind enhancement

Fixes #901

Release Note

Adds a CLI for managing global confuration settings via the 'config' subcommand

Docs

@lkingland lkingland added this to the Release 1.10 milestone Mar 14, 2023
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Mar 14, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2023
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 14, 2023
@lance lance modified the milestones: Release 1.10, Release 1.11 May 16, 2023
@lkingland lkingland removed this from the Release 1.11 milestone Jul 18, 2023
@lkingland lkingland self-assigned this Jul 18, 2023
@github-actions
Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2023
@github-actions github-actions bot closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Global configuration for functions
3 participants