Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s min k8s version to 1.19 #2157

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Bump k8s min k8s version to 1.19 #2157

merged 3 commits into from
Jun 15, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 15, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 15, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2021
@nak3 nak3 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
nak3
nak3 commented Jun 15, 2021
View reviewed changes
version/version.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 15, 2021 •
edited
Loading

Codecov Report

Merging #2157 (535e58b) into main (b2bf37c) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 535e58b differs from pull request most recent head 853f959. Consider uploading reports for the commit 853f959 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
- Coverage   65.90%   65.86%   -0.05%     
==========================================
  Files         221      221              
  Lines        9363     9363              
==========================================
- Hits         6171     6167       -4     
- Misses       2914     2916       +2     
- Partials      278      280       +2
Impacted Files Coverage Δ
version/version.go 87.50% <ø> (ø)
test/gcs/mock/mock.go 90.32% <0.00%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bf37c...853f959. Read the comment docs.

nak3
nak3 commented Jun 15, 2021
View reviewed changes
version/version.go
@@ -32,9 +32,8 @@ const (

// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/main/docs/install/any-kubernetes-cluster.md#before-you-begin
// https://github.com/knative/docs/blob/main/docs/install/knative-with-operators.md#prerequisites
Copy link
Contributor Author

@nak3 nak3 Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link was removed by https://github.com/knative/docs/pull/3732/files.

@nak3 nak3 mentioned this pull request Jun 15, 2021
Merged
@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@dprotaso
Copy link
Member

I always forget this file :)

@knative-prow-robot knative-prow-robot merged commit 77ff8d9 into knative:main Jun 15, 2021
@jerop jerop mentioned this pull request Aug 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nak3 @dprotaso @knative-prow-robot