Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s min k8s version to 1.19 #2157

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Bump k8s min k8s version to 1.19 #2157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76c7733
Bump min k8s version to 1.19
nak3 Jun 15, 2021
535e58b
Fix link
nak3 Jun 15, 2021
853f959
Update link to mkdoc's
nak3 Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ const (

// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/main/docs/install/any-kubernetes-cluster.md#before-you-begin
// https://github.com/knative/docs/blob/main/docs/install/knative-with-operators.md#prerequisites
Copy link
Contributor Author

@nak3 nak3 Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link was removed by https://github.com/knative/docs/pull/3732/files.

defaultMinimumVersion = "v1.18.0"
// https://github.com/knative/docs/blob/mkdocs/docs/snippets/prerequisites.md
defaultMinimumVersion = "v1.19.0"
)

func getMinimumVersion() string {
Expand Down
14 changes: 7 additions & 7 deletions version/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ func TestVersionCheck(t *testing.T) {
wantError bool
}{{
name: "greater version (patch)",
actualVersion: &testVersioner{version: "v1.18.2"},
actualVersion: &testVersioner{version: "v1.19.2"},
}, {
name: "greater version (patch), no v",
actualVersion: &testVersioner{version: "1.18.2"},
actualVersion: &testVersioner{version: "1.19.2"},
}, {
name: "greater version (patch), pre-release",
actualVersion: &testVersioner{version: "1.18.2-kpn-065dce"},
actualVersion: &testVersioner{version: "1.19.2-kpn-065dce"},
}, {
name: "greater version (patch), pre-release, envvar override",
actualVersion: &testVersioner{version: "1.15.11-kpn-065dce"},
Expand All @@ -58,16 +58,16 @@ func TestVersionCheck(t *testing.T) {
versionOverride: "1.15.11-0",
}, {
name: "greater version (minor)",
actualVersion: &testVersioner{version: "v1.18.0"},
actualVersion: &testVersioner{version: "v1.19.0"},
}, {
name: "same version",
actualVersion: &testVersioner{version: "v1.18.0"},
actualVersion: &testVersioner{version: "v1.19.0"},
}, {
name: "same version with build",
actualVersion: &testVersioner{version: "v1.18.0+k3s.1"},
actualVersion: &testVersioner{version: "v1.19.0+k3s.1"},
}, {
name: "same version with pre-release",
actualVersion: &testVersioner{version: "v1.18.0-k3s.1"},
actualVersion: &testVersioner{version: "v1.19.0-k3s.1"},
}, {
name: "smaller version",
actualVersion: &testVersioner{version: "v1.14.3"},
Expand Down