Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup knative-internal-tls secrets #14394

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

ReToCode
Copy link
Member

Partially #14392

Proposed Changes

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2023
@ReToCode
Copy link
Member Author

/assign @nak3
/assign @KauzClay

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (45eaa1d) 86.13% compared to head (67af974) 86.09%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14394      +/-   ##
==========================================
- Coverage   86.13%   86.09%   -0.04%     
==========================================
  Files         196      196              
  Lines       14790    14790              
==========================================
- Hits        12739    12734       -5     
- Misses       1743     1749       +6     
+ Partials      308      307       -1     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@knative-prow knative-prow bot merged commit 127a351 into knative:main Sep 20, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants