Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup knative-internal-tls secrets #14394

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Cleanup knative-internal-tls secrets #14394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions config/core/300-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,19 @@ metadata:
labels:
serving-certs-ctrl: "data-plane"
networking.internal.knative.dev/certificate-uid: "serving-certs"
# The data is populated when internal-encryption is enabled.
# The data is populated when knative-internal-tls is enabled.
---
apiVersion: v1
kind: Secret
metadata:
# this is the legacy secret
# we can drop this once all net-* implementations are using the new `routing-serving-certs` secret
name: knative-serving-certs
namespace: knative-serving
labels:
serving-certs-ctrl: "data-plane"
networking.internal.knative.dev/certificate-uid: "serving-certs"
# The data is populated when internal-encryption is enabled.
---
apiVersion: v1
kind: Secret
metadata:
name: control-serving-certs
namespace: knative-serving
labels:
serving-certs-ctrl: "control-plane"
networking.internal.knative.dev/certificate-uid: "serving-certs"
# The data is populated when internal-encryption is enabled.
# The data is populated when knative-internal-tls is enabled.
---
apiVersion: v1
kind: Secret
Expand All @@ -51,6 +43,5 @@ metadata:
namespace: knative-serving
labels:
serving-certs-ctrl: "data-plane-routing"
routing-id: "0"
networking.internal.knative.dev/certificate-uid: "serving-certs"
# The data is populated when internal-encryption is enabled.
# The data is populated when knative-internal-tls is enabled.
Loading