Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoscaler fetches metrics via a client from the collector. #4007

Merged
merged 7 commits into from
May 9, 2019
Merged

Autoscaler fetches metrics via a client from the collector. #4007

merged 7 commits into from
May 9, 2019

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented May 6, 2019 •
edited
Loading

This inverses the control of the metrics and makes the autoscaler obtain metrics from the collector vs. aggregating them in the autoscaler itself.

It is the last step to fully encapsulate metric collection/aggregation from the autoscaler itself and will make it possible to front the metric collector with the custom-metrics API.

Release Note

NONE

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 6, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot
knative-prow-robot reviewed May 6, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

This inverses the control of the metrics and makes the autoscaler obtain metrics from the collector vs. aggregating them in the autoscaler itself.

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@knative-prow-robot knative-prow-robot added area/autoscale size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2019
@markusthoemmes markusthoemmes force-pushed the autoscaler-client branch 2 times, most recently from a0df6be to 297add1 Compare May 6, 2019 17:59
@markusthoemmes markusthoemmes changed the title [WIP] Autoscaler fetches metrics via a client from the collector. Autoscaler fetches metrics via a client from the collector. May 6, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2019
@markusthoemmes
Copy link
Contributor Author

/assign @greghaynes
/assign @yanweiguo

vagababov
vagababov reviewed May 6, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficial comments only.

pkg/autoscaler/aggregation/bucketing.go Outdated Show resolved Hide resolved
pkg/autoscaler/collector.go Show resolved Hide resolved
@yanweiguo
Copy link
Contributor

LGTM

@markusthoemmes
Copy link
Contributor Author

@vagababov @yanweiguo Rebased and incorporated your feedback. Ready for another look.

@markusthoemmes
Copy link
Contributor Author

Rebased again.

yanweiguo
yanweiguo reviewed May 7, 2019
View reviewed changes
pkg/autoscaler/collector.go Outdated Show resolved Hide resolved
pkg/autoscaler/autoscaler.go Show resolved Hide resolved
@markusthoemmes
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

@markusthoemmes
Copy link
Contributor Author

@yanweiguo thanks for the comments. Feedback has been addressed and the PR has been rebased again.

vagababov
vagababov reviewed May 9, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits.

pkg/autoscaler/collector_test.go Outdated Show resolved Hide resolved
pkg/autoscaler/autoscaler.go Show resolved Hide resolved
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/autoscaler/autoscaler.go 96.9% 94.8% -2.1
pkg/autoscaler/collector.go 98.1% 98.7% 0.6
pkg/autoscaler/multiscaler.go 95.2% 92.6% -2.6

vagababov
vagababov reviewed May 9, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@knative-prow-robot knative-prow-robot merged commit c425b53 into knative:master May 9, 2019
@josephburnett josephburnett mentioned this pull request Jun 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@yanweiguo yanweiguo yanweiguo left review comments

@vagababov vagababov vagababov left review comments

@greghaynes greghaynes Awaiting requested review from greghaynes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@greghaynes greghaynes

@vagababov vagababov

@yanweiguo yanweiguo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@markusthoemmes @knative-prow-robot @yanweiguo @knative-metrics-robot @vagababov @mattmoor-sockpuppet @greghaynes @googlebot