Move Metric interfaces into the general autoscaling package. #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be KPA specific but will soon be needed to be used by HPA resources as well to trigger metric collection. Decider interfaces and types stay KPA specific.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/L
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
This used to be KPA specific but will soon be needed to be used by HPA resources as well to trigger metric collection. Decider interfaces and types stay KPA specific.
Proposed Changes
- Move Metric interfaces into the general autoscaling package.
- Move the Metrics resource interface next to the metric implementation.
- Move Deciders interface for consistency.
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on pkg/.
|
|
/assign @vagababov |
vagababov
added a commit
to vagababov/serving
that referenced
this pull request
Jun 4, 2019
Move to corev1.PodSpec now that vN-1 supports the containers field. (knative#4221) Previously we defined our own partial PodSpec because the corev1 version lacks `omitempty` and appears as `containers: null` in requests from generated clients, even if unspecified, which would have broken webhook validation. Now that the field has been out for a release, we can switch to the common PodSpec. Scaling Roadmap 2019 (knative#3040) * Scaling 2019 roadmap stub. * Descriptions for all 2019 goals. * Goals, POCs and Github projects for each. * Remove recap (will do later). * Remove indent. * Add Pluggability and HPA line item. * Yanwei as POC for layering. * Update docs/roadmap/scaling-2019.md Co-Authored-By: josephburnett <josephburnett79@gmail.com> * Update docs/roadmap/scaling-2019.md Co-Authored-By: josephburnett <josephburnett79@gmail.com> * Clarify overload handling for 0 and non-0 cases. * Refactor cold-start goal. * Remove POC. * Autoscaler scalability. * More edits. * HPA Interation. * Minor edits. * Propose section on migration K8s Deployments * Reworked parts of the Scaling roadmap. - Unified some wording (capitalization mostly). - Removed prescriptive key steps. These should be captured by the respective projects, which will be more dynamically changeable than this document. Enable setting the resource request/limits via annotations for queue-proxy side-car container (knative#4151) * Enable setting the resource request/limits via annotations for queue-proxy side-car container * Last PR comments * more * added integration tests * more * testfix * integrationtest * comments * integration test fix * PR comments * more * final * more pr comments * added error ErrInvalidValue * code coverage of queue.go Remove unused constants. (knative#4238) Update DEVELOPMENT.md (knative#4230) Auto TLS landed in v0.6, so this documentation is out of date golang format tools (knative#4241) Produced via: `gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))` `goimports -w $(find -name '*.go' | grep -v vendor)` Move Metric interfaces into the general autoscaling package. (knative#4236) * Move Metric interfaces into the general autoscaling package. This used to be KPA specific but will soon be needed to be used by HPA resources as well to trigger metric collection. Decider interfaces and types stay KPA specific. * Move the Metrics resource interface next to the metric implementation. * Move Deciders interface for consistency. Apply various fixes pointed out by staticcheck. (knative#4242) * Transform string(buf.Bytes()) to buf.String(). * Remove a bunch of unused code. * Fix error capitalization. * Fix issue with error overlapping. * Fix deprecated usage of Apps without version. * Fix file permission resolution. * Fix comparison to boolean. * Fix issue with variable never being used. * Remove unused conditionsets. * Fix error checks after fixing capitalization. * Remove unused values in performance tests. * Remove some more unused code. steadier state Format markdown (knative#4240) Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)` Drop DeprecatedName from service_test.go (knative#4243) some junk things work
joshrider
pushed a commit
to joshrider/serving
that referenced
this pull request
Jun 10, 2019
…#4236) * Move Metric interfaces into the general autoscaling package. This used to be KPA specific but will soon be needed to be used by HPA resources as well to trigger metric collection. Decider interfaces and types stay KPA specific. * Move the Metrics resource interface next to the metric implementation. * Move Deciders interface for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be KPA specific but will soon be needed to be used by HPA resources as well to trigger metric collection. Decider interfaces and types stay KPA specific.
Proposed Changes
Release Note