Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ggcr #4430

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Bump ggcr #4430

merged 2 commits into from
Jun 24, 2019

Conversation

jonjohnsonjr
Copy link
Contributor

Pick up google/go-containerregistry#470 so we can address #4155

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 19, 2019
@jonjohnsonjr
Copy link
Contributor Author

/assign @mattmoor

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 19, 2019
mattmoor
mattmoor reviewed Jun 19, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I thought I approved this earlier 🤔

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonjohnsonjr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@jonjohnsonjr
Copy link
Contributor Author

I thought I approved this earlier 🤔

You approved this upstream and you approved a different PR for the nvcr.io fix.

@jonjohnsonjr jonjohnsonjr mentioned this pull request Jun 19, 2019
Merged
@jonjohnsonjr
Copy link
Contributor Author

/retest

@mattmoor
Copy link
Member

needs a rebase

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2019
@jonjohnsonjr
Copy link
Contributor Author

@mattmoor rebased

@mattmoor
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@mattmoor
Copy link
Member

/retest

boskos

@jonjohnsonjr
Copy link
Contributor Author

/retest

2 similar comments
@mattmoor
Copy link
Member

/retest

@mattmoor
Copy link
Member

/retest

@jonjohnsonjr
Copy link
Contributor Author 

Time to delete pods = 3m29.275283928s, want < 3m0s

I hate this test

@jonjohnsonjr
Copy link
Contributor Author

/retest

4 similar comments
@jonjohnsonjr
Copy link
Contributor Author

/retest

@jonjohnsonjr
Copy link
Contributor Author

/retest

@mattmoor
Copy link
Member

/retest

@mattmoor
Copy link
Member

/retest

@knative-prow-robot knative-prow-robot merged commit e3c9a6e into knative:master Jun 24, 2019
@jonjohnsonjr jonjohnsonjr deleted the bump-ggcr branch June 8, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonjohnsonjr @knative-prow-robot @mattmoor @googlebot