Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag resolution for schema 1 manifests #4432

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fix tag resolution for schema 1 manifests #4432

merged 1 commit into from
Jun 25, 2019

Conversation

jonjohnsonjr
Copy link
Contributor

@jonjohnsonjr jonjohnsonjr commented Jun 19, 2019 •
edited
Loading

Fixes #4155

This is a workaround for #3997 that doesn't break quay.io images.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 19, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 19, 2019
knative-prow-robot
knative-prow-robot reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonjohnsonjr: 0 warnings.

In response to this:

Fixes #4155

Based on #4430

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jun 19, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2019
@jonjohnsonjr jonjohnsonjr force-pushed the schema1-fix branch 2 times, most recently from ec74a10 to ace3323 Compare June 24, 2019 17:12
@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review June 24, 2019 18:05
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2019
@jonjohnsonjr
Copy link
Contributor Author

/assign @mattmoor

We probably want to hold off until after the release.

mattmoor
mattmoor reviewed Jun 24, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit, but LGTM.

I'll add this to my list of post-cut PRs to approve (or /hold cancel) if you get it updated.

pkg/reconciler/revision/resolve.go Outdated Show resolved Hide resolved
@jonjohnsonjr jonjohnsonjr changed the title Schema1 fix Fix tag resolution for schema 1 manifests Jun 25, 2019
@jonjohnsonjr
Fix tag resolution for schema 1 images
610c5d8 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/revision/resolve.go 92.3% 90.3% -2.0

@mattmoor
Copy link
Member

/lgtm
/approve
/hold

Waitint for 0.7 cut, I'll remove the /hold after we cut.

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonjohnsonjr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@mattmoor
Copy link
Member

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2019
@knative-prow-robot knative-prow-robot merged commit 5eded04 into knative:master Jun 25, 2019
@jonjohnsonjr jonjohnsonjr mentioned this pull request Jun 25, 2019
Merged
@jonjohnsonjr jonjohnsonjr deleted the schema1-fix branch June 25, 2019 18:04
hohaichi pushed a commit to hohaichi/serving that referenced this pull request Jun 25, 2019
@jonjohnsonjr @hohaichi
Fix tag resolution for schema 1 images (knative#4432)
a7ae05a 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@dgerd dgerd Awaiting requested review from dgerd

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to pull images in 0.6 release
5 participants
@jonjohnsonjr @knative-metrics-robot @mattmoor @knative-prow-robot @googlebot