Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in test/README.md #689

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix typo in test/README.md #689

merged 1 commit into from
Apr 19, 2018

Conversation

adrcunha
Copy link
Contributor

Follow-up from #686.

@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2018
@adrcunha adrcunha mentioned this pull request Apr 18, 2018
Merged
@bobcatfish
Copy link
Contributor

ugh, sorry @adrcunha I shouldn't have /lgtm-ed that previous request >.<

@adrcunha
Copy link
Contributor Author

No worries at all, you can /lgtm and /approve this one. ;)

@bobcatfish
Copy link
Contributor

No worries at all, you can /lgtm and /approve this one. ;)

I'm going to get the hang of this one day XD

@bobcatfish
Copy link
Contributor

/meow space

@google-prow-robot
Copy link

@bobcatfish: cat image

In response to this:

/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobcatfish
Copy link
Contributor

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha
Copy link
Contributor Author

adrcunha commented Apr 19, 2018 •
edited
Loading

@bobcatfish can I haz GitHub approval plz?

@bobcatfish
Copy link
Contributor

@bobcatfish can I haz GitHub approval plz?

omg

@google-prow-robot google-prow-robot merged commit 4fddea4 into knative:master Apr 19, 2018
skonto added a commit to skonto/serving that referenced this pull request Apr 24, 2024
@skonto
Merge pull request knative#689 from skonto/update_build_image_1.12
66d0b55 
[RELEASE-1.12] update build image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish approved these changes

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrcunha @bobcatfish @google-prow-robot