-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to run the end-to-end tests #686
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This solves #636 as well! |
The docs is so small these links seem to go nowhere at the moment, but that will change as we add more testing docs.
/hold |
tar xf kubetest-darwin-amd64.tar.gz | ||
cp kubetest /usr/local/bin | ||
``` | ||
2. Have the `PROJECT_ID` environment variable set to a GCP project you own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean it's not possible to run the e2e tests against any non GCP-based k8s clusters?
do we have an issue to make the e2e tests work for other kinds of clusters? seems important before we open this project up, if we expect contributors to run them (which reminds me i should probably up the priority of #609 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that you can run the tests by simply calling the script with --run-tests
. Thanks for bringing my attention to that. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah cool! I didn't know you could do that :D
/hold cancel |
|
||
You can either run all the end-to-end tests in an isolate, hermetic cluster, or use your already existing cluster for that. | ||
|
||
### Running against an isolate, hermetic cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: isolated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #689, please review at your convenience.
/lgtm |
Fixes #636.