Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to run the end-to-end tests #686

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Document how to run the end-to-end tests #686

merged 3 commits into from
Apr 18, 2018

Conversation

adrcunha
Copy link
Contributor

@adrcunha adrcunha commented Apr 18, 2018

Fixes #636.

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2018
@bobcatfish
Copy link
Contributor

This solves #636 as well!

The docs is so small these links seem to go nowhere at the moment, but that will change as we add more testing docs.
@bobcatfish
Copy link
Contributor

/hold
/lgtm

@google-prow-robot google-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 18, 2018
tar xf kubetest-darwin-amd64.tar.gz
cp kubetest /usr/local/bin
```
2. Have the `PROJECT_ID` environment variable set to a GCP project you own.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean it's not possible to run the e2e tests against any non GCP-based k8s clusters?

do we have an issue to make the e2e tests work for other kinds of clusters? seems important before we open this project up, if we expect contributors to run them (which reminds me i should probably up the priority of #609 😅)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that you can run the tests by simply calling the script with --run-tests. Thanks for bringing my attention to that. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah cool! I didn't know you could do that :D

@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2018
@adrcunha
Copy link
Contributor Author

/hold cancel

@google-prow-robot google-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2018

You can either run all the end-to-end tests in an isolate, hermetic cluster, or use your already existing cluster for that.

### Running against an isolate, hermetic cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: isolated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #689, please review at your convenience.

@bobcatfish
Copy link
Contributor

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2018
@google-prow-robot google-prow-robot merged commit d93d1f5 into knative:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants