Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow enableServiceLinks to be set #8439

Merged
merged 2 commits into from
Jun 27, 2020
Merged

allow enableServiceLinks to be set #8439

merged 2 commits into from
Jun 27, 2020

Conversation

dprotaso
Copy link
Member

Fixes #6074

Proposed Changes

  • Allow service links to be disabled (the property defaults to true)

Release Note

enableServiceLinks can be set on the PodSpec template

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels Jun 23, 2020
knative-prow-robot
knative-prow-robot reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprotaso: 0 warnings.

In response to this:

Fixes #6074

Proposed Changes

  • Allow service links to be disabled (the property defaults to true)

Release Note

enableServiceLinks can be set on the PodSpec template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@dprotaso
Copy link
Member Author

/assign markusthoemmes

@MIBc
Copy link
Contributor

MIBc commented Jun 24, 2020 •
edited
Loading

I patch it in knative 0.13.0 and rebuild webhook. The deployment which created by ksvc does not have EnableServiceLinks config.

@dprotaso
Copy link
Member Author

/hold

yeah you're right - I see the issue

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@knative-prow-robot knative-prow-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2020
@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 24, 2020
@dprotaso
Copy link
Member Author

@MIBc thanks for reviewing/trying out the diff

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/fieldmask.go 97.9% 97.9% 0.0

@markusthoemmes markusthoemmes mentioned this pull request Jun 25, 2020
Closed
@dprotaso
Copy link
Member Author

@markusthoemmes this PR is good now

mattmoor
mattmoor reviewed Jun 27, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor mentioned this pull request Jun 27, 2020
Closed
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 8051c8b into knative:master Jun 27, 2020
@dprotaso dprotaso deleted the service-links branch June 29, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor mattmoor left review comments

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@markusthoemmes markusthoemmes

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set EnableServiceLinks in PodSpec
8 participants
@dprotaso @MIBc @knative-metrics-robot @knative-prow-robot @knative-test-reporter-robot @mattmoor @markusthoemmes @googlebot