Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow enableServiceLinks to be set #8439

Merged
merged 2 commits into from
Jun 27, 2020
Merged

allow enableServiceLinks to be set #8439

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c901496
allow enableServiceLinks to be set
dprotaso Jun 23, 2020
f5bbb5c
pass through podspec properties that were allowed by the webhook
dprotaso Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/serving/fieldmask.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func PodSpecMask(in *corev1.PodSpec) *corev1.PodSpec {
out.Containers = in.Containers
out.Volumes = in.Volumes
out.ImagePullSecrets = in.ImagePullSecrets
out.EnableServiceLinks = in.EnableServiceLinks

// Disallowed fields
// This list is unnecessary, but added here for clarity
Expand Down Expand Up @@ -175,7 +176,6 @@ func PodSpecMask(in *corev1.PodSpec) *corev1.PodSpec {
out.DNSConfig = nil
out.ReadinessGates = nil
out.RuntimeClassName = nil
// TODO(mattmoor): Coming in 1.13: out.EnableServiceLinks = nil

return out
}
Expand Down