Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge I128/Ixx and U28/Uxx variants #314

Closed
Lotterleben opened this issue Dec 18, 2020 · 0 comments · Fixed by #323
Closed

Merge I128/Ixx and U28/Uxx variants #314

Lotterleben opened this issue Dec 18, 2020 · 0 comments · Fixed by #323
Labels
difficulty: easy Pretty easy to solve good first issue Good for newcomers type: refactor parts of the code that should be improved or redesigned

Comments

@Lotterleben
Copy link
Contributor

Currently, the Arg enum has two matching *xx/*128 variants which are treated the same e.g. in format_args_real(). They should be merged into one,
@Lotterleben Lotterleben added good first issue Good for newcomers difficulty: easy Pretty easy to solve type: refactor parts of the code that should be improved or redesigned labels Dec 18, 2020
@Sh3Rm4n Sh3Rm4n mentioned this issue Dec 20, 2020
Merged
bors bot added a commit that referenced this issue Jan 4, 2021
@bors @Sh3Rm4n
Merge #323
666a205 
323: Merge I128/Ixx and U128/Uxx variants r=japaric a=Sh3Rm4n

Closes #314 

Also lift 32 bit range for bitfields introduced in #13
Could be split into another PR, if concerns are raised.

Co-authored-by: Fabian Viöl <f.vioel@googlemail.com>
@bors bors bot closed this as completed in 41a5937 Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy Pretty easy to solve good first issue Good for newcomers type: refactor parts of the code that should be improved or redesigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge I128/Ixx and U128/Uxx variants Sh3Rm4n/defmt
1 participant
@Lotterleben