Merge I128/Ixx and U128/Uxx variants #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh3Rm4n
changed the title
Sh3Rm4n
force-pushed
the
u128i128
branch
2 times, most recently
from
017784b to
330cd0a
Compare
|
Looks reasonable, thanks! I think we should add a QEMU test for the larger bitfield range. |
Range is exclusive. To match the MSB 32 for `range.end` has to be allowed.
#[clippy(warn::or_fun_call)]
|
I've added a qemu test and as it showed, some more places had to be changed to support 128 bitfields. I've also added ascii hint support for bitfields :) |
japaric
reviewed
Jan 4, 2021
| @@ -1608,6 +1621,31 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn bitfields_u128() { | |||
There was a problem hiding this comment.
I was a bit surprised about this test because expected that {0=119..124:b} is encoded as 2 bytes instead of as 16 bytes. After checking locally, this test also works if I remove the last 14 bytes. It would be nice to make decode_and_expect check that the input data was fully consumed to ensure we are not passing extra bytes that will be ignored.
japaric
approved these changes
Jan 4, 2021
|
bors r+ |
|
Build failed: |
|
CI should be fixed now |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #314
Also lift 32 bit range for bitfields introduced in #13
Could be split into another PR, if concerns are raised.