Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding docs. #568

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Encoding docs. #568

merged 2 commits into from
Sep 6, 2021

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Sep 5, 2021 •
edited
Loading

  • Document Encoder.
  • Document in Logger that implementations MUST pass all the data through Encoder.
  • Add user-facing docs on the available encoding features in Cargo.toml (you may want to copy/move those to the book?)
  • Minor fixes.

Fixes #567

This was referenced Sep 5, 2021
Merged
Merged
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 6, 2021

Build succeeded:

@bors bors bot merged commit c4e1004 into knurling-rs:main Sep 6, 2021
@Urhengulas
Copy link
Member

Thank you @Dirbaio! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing doc-comments for defmt::Encoder
3 participants
@Dirbaio @jonas-schievink @Urhengulas