-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not setting headers on Koa2 / Node 6.2 #18
Comments
same issue here |
can you give a simple code(server and client) to reproduce the issue? |
Using koa2! On server:
On Client (origin different than server): |
This is still an issue, still waiting on the PR to be merged |
Still seeing this as an issue as well. The PR above does not seem to fix it, however. As referenced in the PR, it is setting the allowed origin to the origin of the responding server. |
…- Not setting headers on Koa2 / Node 6.2 As Origin header is not set in all fetch. I understand that we need to be able to validade, even if the origin is not present. We are still following https://fetch.spec.whatwg.org/#http-origin but grating headers to be added to response on user needs
I just opened a PR. Hope it is still in time :) |
As Origin header is not set in all fetch. I understand that we need to be able to validade, even if the origin is not present. We are still following https://fetch.spec.whatwg.org/#http-origin but grating headers to be added to response on user needs Fix #18
The headers don't seem to be getting set on the latest version of Koa 2 with node 6.2. Any ideas?
The text was updated successfully, but these errors were encountered: